Skip to content
This repository has been archived by the owner on Mar 10, 2024. It is now read-only.

Update Node support to v16, CI to 18 #182

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Update Node support to v16, CI to 18 #182

merged 3 commits into from
Oct 1, 2023

Conversation

ryanwilsonperkin
Copy link
Collaborator

@ryanwilsonperkin ryanwilsonperkin commented Sep 28, 2023

Node v14 is presenting some issues for #181
The new version of the @typescript-eslint library that unimported relies on makes use of features like the conditional assignment operator which wasn't added until Node v15.

Given the LTS support schedule, it seems reasonable to drop the explicit support for Node v14 that's used in CI and update to v16 for support(still out of date, but less so) and v18 for testing (LTS support window).

@smeijer
Copy link
Owner

smeijer commented Oct 1, 2023

Thanks! Tho, given that node 16 is EOL as well, I agree that we should upgrade to v18 at a minimum. Can you make it so?

@smeijer
Copy link
Owner

smeijer commented Oct 1, 2023

If you want, we can also take a stab at matrix testing and running tests against both 18 and 20. That way we could recommend 20, but ensure compatibility with 18.

@ryanwilsonperkin
Copy link
Collaborator Author

Could I suggest supporting engines >=16 but testing on 18 & 20?
Benefit being that it's not currently using any >=18 exclusive libraries, and can thus still technically support v16 apps without issuing warnings, or failing to install on strict configs. I've got at least one v16 app that hasn't yet upgraded that I'd like to be able to use this library against in the meantime.

@smeijer
Copy link
Owner

smeijer commented Oct 1, 2023

That works for me. I was mostly concerned about the github workflow. I think we should run it on a supported version. I'm not going to forbid a consumer to use the lib in their v16 env when we can reasonably support it. 🙂

@ryanwilsonperkin ryanwilsonperkin changed the title Update Node in CI to v16 Update Node support to v16, CI to 18 Oct 1, 2023
@smeijer
Copy link
Owner

smeijer commented Oct 1, 2023

Thank you!

FYI, this repo qualifies for hacktoberfest contributions if that's your thing.

@smeijer smeijer merged commit a7a824b into main Oct 1, 2023
13 checks passed
@smeijer smeijer deleted the bump-node-v16 branch October 1, 2023 19:21
@smeijer
Copy link
Owner

smeijer commented Nov 18, 2023

🎉 This PR is included in version 1.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants