Remove ProviderConfig as the configuration source for AssumeRoleProvider #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
reviewed
Sep 29, 2023
Comment on lines
+399
to
+401
| panic!("don't call me — will be overridden"); | ||
| #[allow(unreachable_code)] | ||
| Ok(Credentials::for_tests()) |
There was a problem hiding this comment.
Suggested change
| panic!("don't call me — will be overridden"); | |
| #[allow(unreachable_code)] | |
| Ok(Credentials::for_tests()) | |
| panic!("don't call me — will be overridden") |
There was a problem hiding this comment.
you need this for inference
| @@ -602,4 +602,22 @@ impl SdkConfig { | |||
| pub fn builder() -> Builder { | |||
| Builder::default() | |||
| } | |||
|
|
|||
| /// Convert this [`SdkConfig`] back to a builder to enable modification | |||
| pub fn to_builder(self) -> Builder { | |||
There was a problem hiding this comment.
This is awesome!
The to_builder() on the generated configs takes &self rather than self. Should this be consistent?
| @@ -51,6 +51,11 @@ impl StaticTimeSource { | |||
| pub fn new(time: SystemTime) -> Self { | |||
| Self { time } | |||
| } | |||
|
|
|||
| /// Creates a new static time source from the provided number of seconds since the UNIX epoch | |||
| pub fn new_from_epoch(epoch_secs: u64) -> Self { | |||
There was a problem hiding this comment.
This is called from_secs on our DateTime. Should we use the same name here?
rcoh
force-pushed
the
assume-role-provider
branch
from
a59412c to
df9496a
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
assume-role-provider
branch
from
b795ee7 to
22f1b4b
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Sep 29, 2023
jdisanti
approved these changes
Sep 29, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
AssumeRoleProvidercurrently usesProviderConfigas a source of configuration, but that API is hard use and not intended for external consumption.This fixes the Assume Role issue but only for
AssumeRoleProviderDescription
Update the API (see changelog) to be more ergonomic and derive configuration from
SdkConfiginstead.Testing
Existing tests + new unit tests
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.