Render smoke tests for services without support for account ID routing #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velfi
approved these changes
Aug 28, 2024
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
deleted the
ysaito/render-smoke-tests-without-acct-id-routing
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
## Motivation and Context Restores `SmokeTestsDecoratorTest` that was temporarily removed in #3808. ## Description The said test was temporarily removed because `SmokeTestsDecorator` is included in the [predefined decorators](https://github.com/smithy-lang/smithy-rs/blob/b38ccb969e09ae0856c235fcb496b3f3faf41c87/aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/AwsCodegenDecorator.kt#L35) and pulls-in the `aws-config` crate for code generation. The issue was conflicts between the runtime crates used by `aws-config` (located in the `aws/sdk/build` directory) and those brought-in by that predefined decorators used by `awsSdkIntegrationTest` (located in the `rust-runtime` and `aws/rust-runtime` directories). This PR addresses these conflicts and restores the test functionality. Given the challenges, the code changes are centered around the following ideas: - Focus solely on testing the core class, `SmokeTestsInstantiator`. By doing this, we avoid running `SmokeTestsDecorator`, which would otherwise pull in the `aws-config` crate. - Initializing a config builder in smoke tests needs to be parameterized depending on the environment; in production we use `aws_config::load_defaults` and in testing we avoid including `aws-config` by using a default-constructed config builder, which is sufficient for compile-only tests. - The generated smoke tests in `SmokeTestsDecoratorTest` require minimal runtime crates for compilation. We need the `CodegenVisitor` but with a different set of codegen decorators. Prior to this PR, `awsSdkIntegrationTest` used [RustClientCodegenPlugin](https://github.com/smithy-lang/smithy-rs/blob/b38ccb969e09ae0856c235fcb496b3f3faf41c87/codegen-client/src/main/kotlin/software/amazon/smithy/rust/codegen/client/smithy/RustClientCodegenPlugin.kt#L46) that in turn loaded [predefined decorators](https://github.com/smithy-lang/smithy-rs/blob/b38ccb969e09ae0856c235fcb496b3f3faf41c87/aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/AwsCodegenDecorator.kt#L35) on the classpath, which included `SmokeTestsDecorator`. In this PR, we work around this by defining a minimal set of codegen decorators and making them pluggable through `awsSdkIntegrationTest`. ## Testing Tests in CI ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Follow-up on #3799
Description
This PR updates the smoke test rendering process for services whose models specify the
smokeTeststrait (example). Previously,SmokeTestsDecoratorskipped rendering whenuseAccountIdRoutingwas set to true in the vendor parameters, which is the default forAwsVendorParams. Even though the Rust SDK does not currently support the account ID routing, it is safe to render these tests. This is because existing smoke tests do not rely on this feature, and when account ID routing is used, the Rust SDK will fall back to other means to sourcing the identity.This PR includes a minor fix: it uses
aws_configto load default configurations.config::Builder::new()would have no credentials provider chain available, which would then result in test failures at runtime.By bringing
aws-config, theSmokeTestsDecoratorTestno longer works, since the AWS runtime crates required byaws-configconflict with those generated byawsSdkIntegrationTest(a known limitation). For example:Therefore, we removed
SmokeTestsDecoratorTest.ktonly in this PR to ship the feature, but are planning to restore it in the next PR by directly testingSmokeTestsInstantiatorwithout usingawsSdkIntegrationTest.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.