-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore SmokeTestsDecoratorTest
#3811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
approved these changes
Sep 3, 2024
aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/SmokeTestsDecorator.kt
Outdated
Show resolved
Hide resolved
aws/sdk-codegen/src/test/kotlin/software/amazon/smithy/rustsdk/SmokeTestsDecoratorTest.kt
Outdated
Show resolved
Hide resolved
A new generated diff is ready to view.
A new doc preview is ready to view. |
This commit addresses #3811 (comment)
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
reviewed
Sep 4, 2024
aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/SmokeTestsDecorator.kt
Show resolved
Hide resolved
Velfi
approved these changes
Sep 4, 2024
aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/SmokeTestsDecorator.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Restores
SmokeTestsDecoratorTest
that was temporarily removed in #3808.Description
The said test was temporarily removed because
SmokeTestsDecorator
is included in the predefined decorators and pulls-in theaws-config
crate for code generation. The issue was conflicts between the runtime crates used byaws-config
(located in theaws/sdk/build
directory) and those brought-in by that predefined decorators used byawsSdkIntegrationTest
(located in therust-runtime
andaws/rust-runtime
directories). This PR addresses these conflicts and restores the test functionality.Given the challenges, the code changes are centered around the following ideas:
SmokeTestsInstantiator
. By doing this, we avoid runningSmokeTestsDecorator
, which would otherwise pull in theaws-config
crate.aws_config::load_defaults
and in testing we avoid includingaws-config
by using a default-constructed config builder, which is sufficient for compile-only tests.SmokeTestsDecoratorTest
require minimal runtime crates for compilation. We need theCodegenVisitor
but with a different set of codegen decorators. Prior to this PR,awsSdkIntegrationTest
used RustClientCodegenPlugin that in turn loaded predefined decorators on the classpath, which includedSmokeTestsDecorator
. In this PR, we work around this by defining a minimal set of codegen decorators and making them pluggable throughawsSdkIntegrationTest
.Testing
Tests in CI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.