Merge smithy-rs-release-1.x.y into main #3819
Merged
+31
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Will merge to the release branch** ## Motivation and Context Fixes a failure observed in our release pipeline ## Description A lockfile located at `aws/sdk/Cargo.lock` did not include the `minicbor` crate that was introduced as part of RPC V2 CBOR. This has caused a build failure in our release pipeline due to a new version of `minicbor` 0.24.3 uploaded to crates.io. ``` error: unsupported output in build script of `minicbor v0.24.3`: `cargo::rustc-check-cfg=cfg(atomic64, atomic32)` ``` To address this issue, this PR pins `minicbor` to 0.24.2 in `aws/sdk/Cargo.lock` (`rust-runtime/Cargo.lock` already pins it to 0.24.2) The change in `aws/sdk/Cargo.lock` was obtained by 1. running `git pull` in `/Users/awsaito/src/aws-sdk-rust` 2. running `./gradlew aws:sdk:generateAllLockfiles -Paws-sdk-rust-path=/Users/awsaito/src/aws-sdk-rust` 3. retaining the portion only relevant to `minicbor` In addition, since the release of aws-sdk-rust the other day, smoke tests have started getting rendered and compiled in cargo-semver-checks. This has caused cargo-semver-checks to exceed the previous timeout of 20 minutes. To address it, we have increased the timeout to 30 minutes. ## Testing - [ ] Tests in CI - [x] End-to-end tests in our release pipeline ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
…erge-smithy-rs-release-1.x.y-to-main"
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Sep 3, 2024
aws-sdk-rust-ci
deleted the
merge-smithy-rs-release-1.x.y-to-main-1725395722
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge it with
gh pr merge --admin --mergeor manually merge it with the merge commit (not squash merge).