Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate http-02x presign APIs #3823

Merged
merged 1 commit into from
Sep 11, 2024
Merged

deprecate http-02x presign APIs #3823

merged 1 commit into from
Sep 11, 2024

Conversation

aajtodd
Copy link
Contributor

@aajtodd aajtodd commented Sep 9, 2024

Motivation and Context

Description

Deprecate http-02x APIs from inlineable PresignedRequest API. These should have been feature gated originally but they weren't. For now we'll mark them deprecated and encourage people to move to the 1.x equivalents.

Checklist

  • [x ] For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

github-actions bot commented Sep 9, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

- aws-sdk-rust
authors:
- aajtodd
references: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
references: []
references: [smithy-rs#3823]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're to always do this, is there a way we can automate this instead of manually recording the PR number every time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not inclined to include PR numbers in changelogs by default.

@aajtodd aajtodd added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit db1a9f1 Sep 11, 2024
44 checks passed
@aajtodd aajtodd deleted the atodd/deprecate-presign branch September 11, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants