Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate http-02x presign APIs #3823

Merged
merged 1 commit into from
Sep 11, 2024
Merged

deprecate http-02x presign APIs #3823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changelog/1725892046.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
applies_to:
- aws-sdk-rust
authors:
- aajtodd
references: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
references: []
references: [smithy-rs#3823]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're to always do this, is there a way we can automate this instead of manually recording the PR number every time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not inclined to include PR numbers in changelogs by default.

breaking: false
new_feature: false
bug_fix: false
---
deprecate http-02x presign APIs in favor of http-1x equivalents
3 changes: 3 additions & 0 deletions aws/rust-runtime/aws-inlineable/src/presigning.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,11 +225,14 @@ impl PresignedRequest {
}

/// Given a body, produce an `http::Request` from this `PresignedRequest`
#[deprecated = "Prefer the `make_http_1x_request()` instead by enabling the `http-1x` feature."]
#[allow(deprecated)]
pub fn make_http_02x_request<B>(&self, body: B) -> http::Request<B> {
self.clone().into_http_02x_request(body)
}

/// Converts this `PresignedRequest` directly into an `http` request.
#[deprecated = "Prefer the `into_http_1x_request` instead by enabling the `http-1x` feature."]
pub fn into_http_02x_request<B>(self, body: B) -> http::Request<B> {
self.http_request
.try_into_http02x()
Expand Down