Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: model bucketing edge case with resource shape #1123

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

atbreuer11
Copy link
Contributor

Issue:
Similar to this issue, when a resource shape is the only model assigned to the last bucket, an export statement for the file is included in index.ts, yet the file is never created, as there is no codgen for resources.

// smithy-typescript generated code
export * from "./models_0";
export * from "./models_1"; // file doesn't exist

Description of changes:

  • Update SymbolVisitor to always place resource shapes in initial bucket
  • Add unit test

@atbreuer11 atbreuer11 requested review from a team as code owners December 21, 2023 14:58
@atbreuer11 atbreuer11 requested a review from hpmellema December 21, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants