model bucketing: special case for smithy.api#Unit #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
approved these changes
Mar 8, 2023
kstich
reviewed
Mar 8, 2023
| bucketCount++; | ||
| currentBucketSize = 0; | ||
| String path; | ||
| if (shape.getId().toString().equals("smithy.api#Unit")) { |
There was a problem hiding this comment.
Can use .getId().equals(UnitTypeTrait.UNIT) instead.
kstich
approved these changes
Mar 8, 2023
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
* model bucketing: special case for smithy.api#Unit * update UnitTypeTrait equality check
|
We are still running into this problem even after updating to 0.15.0 which includes this fix. The problem just happens later. With 0.14.0, the problem happens as soon as we add one more structure to our models. With 0.15.0, it only happens when we add two more structures to our model. Could there be some other shape type that should also default to bucket 0 – same as Unit shapes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an edge case, the only model assigned to the last bucket may be
smithy.api#Unit.This causes the code generator to think that
models_Nexists, but in fact onlymodels_(N-1)exists becauseUnitdoes not generate anything. This causes a compilation error in the generated models index.This proposed fix is to ignore
smithy.api#Unitwhen incrementing the bucketing counter.testing
tested code generation against the edge case unreleased feature