Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error printout for protocol-response tests #657

Merged
merged 3 commits into from
Dec 13, 2022
Merged

Fix Error printout for protocol-response tests #657

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6dc877c
Fix broken reference to `fail()` after jest-upgrade
haydenbaker Nov 22, 2022
5040a91
Merge branch 'awslabs:main' into fix-missing-reference
haydenbaker Dec 13, 2022
f936fa2
Remove interpolation of error in response tests
haydenbaker Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...en/src/main/java/software/amazon/smithy/typescript/codegen/HttpProtocolTestGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ private void generateResponseTest(OperationShape operation, HttpResponseTestCase
writer.write("try {\n"
+ " r = await client.send(command);\n"
+ "} catch (err) {\n"
+ " fail('Expected a valid response to be returned, got:\n\n `${err}`');\n"
+ " fail(\"Expected a valid response to be returned, got \" + err);\n"
+ " return;\n"
+ "}");
writeResponseAssertions(operation, testCase);
Expand Down