Remove reflected values from validation message #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugmanue
approved these changes
Feb 16, 2023
AndrewFossAWS
approved these changes
Feb 16, 2023
gosar
reviewed
Feb 16, 2023
| @@ -170,5 +153,5 @@ export const generateValidationMessage = (failure: ValidationFailure): string => | |||
| suffix = "must have unique values"; | |||
There was a problem hiding this comment.
looks like we are missing tests for this case. can you add some?
There was a problem hiding this comment.
Added here, and to the protocol tests in smithy-lang/smithy#1622.
gosar
reviewed
Feb 27, 2023
| path: "/test", | ||
| }; | ||
| expect(generateValidationMessage(failure)).toEqual( | ||
| "Value with repeated values at '/test' failed to satisfy constraint: Member must have unique values" |
There was a problem hiding this comment.
This reads odd. Was ok when it was Value [80, 80] with repeated values at '/test'.... But now, probably better to say Value at 'test'... similar to the other messages. Would have to update the protocol tests too.
There was a problem hiding this comment.
Ok to merge this now and update when the protocol test is updated.
gosar
approved these changes
Feb 27, 2023
srchase
added a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
* Remove reflected values from validation message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
generateValidationMessageto not return the input value in the validation message.This change will be paired with updated protocol tests: smithy-lang/smithy#1622
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.