Remove reflected values from validation tests #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugmanue
approved these changes
Feb 16, 2023
srchase
force-pushed
the
validation-value-reflection
branch
from
85e6d56 to
e0df073
Compare
sugmanue
approved these changes
Feb 22, 2023
gosar
reviewed
Feb 27, 2023
| mediaType: "application/json", | ||
| assertion: { | ||
| contents: """ | ||
| { "message" : "1 validation error detected. Value with repeated values at '/blobList' failed to satisfy constraint: Member must have unique values", |
There was a problem hiding this comment.
Noticed this in https://github.com/awslabs/smithy-typescript/pull/695/files#r1119201953. This reads odd. Was ok when it was Value [80, 80] with repeated values at '/test'.... But now, probably better to say Value at 'test'... similar to the other messages.
|
This change broke a bunch of our (smithy-rs's) protocol tests when upgrading to |
@jjant yeah we anticipated this might break existing tests, but sorry we forgot to give you the heads up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the validation protocol tests to remove the input value from being returned in the validation message.
It also adds coverage for uniqueItems validation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.