Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javadoc search results link to incorrect URLs #1006

Closed
alex-chew opened this issue Dec 7, 2021 · 2 comments
Closed

Javadoc search results link to incorrect URLs #1006

alex-chew opened this issue Dec 7, 2021 · 2 comments

Comments

@alex-chew
Copy link

From the Javadoc, if I type a symbol name (e.g. ModelAssembler) in the search input and then click on any result, I'm directed to a 404 page. On the other hand, navigating to the desired symbol via the package list works as expected.

I've also noticed that, when my browser loads the Javadoc home page, it gets 404s for the following resources:
@adamthom-amzn
Copy link
Contributor

Looks like https://bugs.openjdk.java.net/browse/JDK-8215291

@adamthom-amzn adamthom-amzn mentioned this issue Dec 8, 2021
Merged
adamthom-amzn added a commit to adamthom-amzn/smithy that referenced this issue Dec 8, 2021
@adamthom-amzn
Fix javadoc search links
b189e9f 
Our javadocs are broken due to JDK bug
https://bugs.openjdk.java.net/browse/JDK-8215291 which is fixed in JDK 12.
We can work around it by specifying --no-module-directories when generating
javadocs.

fixes smithy-lang#1006
@adamthom-amzn
Copy link
Contributor

the links from search will be fixed with the next smithy release, in its javadocs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alex-chew @adamthom-amzn