Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javadoc search links #1009

Merged

Conversation

adamthom-amzn
Copy link
Contributor

Issue #, if available:
#1006

Description of changes:
Our javadocs are broken due to JDK bug
https://bugs.openjdk.java.net/browse/JDK-8215291 which is fixed in JDK 12.
We can work around it by specifying --no-module-directories when generating
javadocs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@adamthom-amzn adamthom-amzn requested a review from a team as a code owner December 8, 2021 19:32
Our javadocs are broken due to JDK bug
https://bugs.openjdk.java.net/browse/JDK-8215291 which is fixed in JDK 12.
We can work around it by specifying --no-module-directories when generating
javadocs.

fixes smithy-lang#1006
@adamthom-amzn adamthom-amzn force-pushed the fix-javadoc-search-links branch from e379017 to b189e9f Compare December 8, 2021 19:44
@adamthom-amzn adamthom-amzn merged commit 982654e into smithy-lang:main Dec 8, 2021
@adamthom-amzn adamthom-amzn deleted the fix-javadoc-search-links branch December 8, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants