Issue #58 - Modal stops passing title/message/href through if modal is canceled #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snipe
added a commit
that referenced
this pull request
Jan 4, 2014
Issue #58 - Modal stops passing title/message/href through if modal is canceled
|
This looks great, thank you! (Sorry for the delay - holidays and a massive office move for my day job.) |
Closed
Closed
2 tasks
2 tasks
Closed
2 tasks
2 tasks
Closed
Closed
2 tasks
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not my plan to reformat the default layout but there were two problems.
First, its indentation was broken. I had to fix it to understand its HTML structure.
Second, tag matching was broken. Every backend/*/index.blade.php misses last closing div. And it was found in the middle of the default layout. I guess it was intended so I left it as it was.
IMHO modal should be in HTML in accordance with the spirit of bootstrap ;) If you rather like lazy init by JavaScript, I sure can change it back to its original concept.
PS. This is my first contribution with 24 Pull Requests. Happy holidays!