Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for SQLAlchemy 2.0 Mapped annotations #179

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Adds support for SQLAlchemy 2.0 Mapped annotations #179

merged 2 commits into from
Dec 7, 2023

Conversation

Daverball
Copy link
Collaborator

Closes #178

@Daverball Daverball requested a review from sondrelg December 7, 2023 08:49
sondrelg
sondrelg approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@sondrelg sondrelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage looks solid, and so does the code. Only really spotted a simple typo - the rest looks good to me 👍

README.md Outdated Show resolved Hide resolved
@sondrelg
Copy link
Member

sondrelg commented Dec 7, 2023

If you'd like to cut a release yourself @Daverball, just:

That will kick off a workflow which publishes the new version to PyPI 👍

@Daverball @sondrelg
Update README.md
d7a40c7 
Co-authored-by: Sondre Lillebø Gundersen <sondrelg@live.no>
@Daverball Daverball merged commit 700cd24 into snok:main Dec 7, 2023
6 checks passed
@Daverball Daverball deleted the feat/sqlalchemy20 branch December 7, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondrelg sondrelg sondrelg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for SQLAlchemy 2.0
2 participants
@Daverball @sondrelg