feat: container command correctly handles DOCKER_HOST #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue with the Bitbucket integration related to using DOCKER_HOST and also some use-cases where users want to provide an external Docker host.
ghost
requested review from
|
Expected release notes (by @ivanstanev) features:
|
JackuB
approved these changes
Oct 23, 2020
gitphill
approved these changes
Oct 23, 2020
maxjeffos
approved these changes
Oct 23, 2020
|
Fixed in #1475. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue with the Bitbucket integration related to using DOCKER_HOST and also some use-cases where users want to provide an external Docker host.
Any background context you want to provide?
snyk/snyk-docker-plugin#286
Slack thread
Slack thread