Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/read docker host env var #286

Merged
merged 3 commits into from
Oct 23, 2020
Merged

Fix/read docker host env var #286

merged 3 commits into from
Oct 23, 2020

Conversation

ivanstanev
Copy link
Contributor

@ivanstanev ivanstanev commented Oct 23, 2020 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

This prevented environment variables like DOCKER_HOST from being read and completely disallowed access to Remote Docker hosts.
This affected our Bitbucket integration and prevented users from interacting with other Remote hosts (e.g. Podman).

Any background context you want to provide?

Slack thread
Slack thread

@ivanstanev
fix: capture errors in debug output
e7458ae 
Errors were not properly formated until now and printed "[object Object]".
@ivanstanev
fix: do not pass hardcoded Docker socket path
70b618b 
This prevented environment variables like DOCKER_HOST from being read and completely disallowed access to Remote Docker hosts.
This affected our Bitbucket integration and prevented users from interacting with other Remote hosts (e.g. Podman).
@ivanstanev
fix: remove unused Docker functionality
edf6726
@ivanstanev ivanstanev requested a review from a team as a code owner October 23, 2020 10:53
@ivanstanev ivanstanev self-assigned this Oct 23, 2020
@github-actions
Copy link

github-actions bot commented Oct 23, 2020 •
edited by ivanstanev
Loading

Expected release notes (by @ivanstanev)

fixes:
remove unused Docker functionality (edf6726)
do not pass hardcoded Docker socket path (70b618b)
capture errors in debug output (e7458ae)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

agranado2k
agranado2k approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@agranado2k agranado2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@ivanstanev ivanstanev merged commit 701cf5c into master Oct 23, 2020
@ivanstanev ivanstanev deleted the fix/read-docker-host-env-var branch October 23, 2020 11:02
@snyksec
Copy link

snyksec commented Oct 23, 2020

🎉 This PR is included in version 4.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ivanstanev ivanstanev mentioned this pull request Oct 23, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agranado2k agranado2k agranado2k approved these changes

Assignees

@ivanstanev ivanstanev

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanstanev @snyksec @agranado2k