Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: revert refactor snyk missing api token #549

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jun 3, 2019

This reverts commit 76b0565.

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

revert a refactor that makes snyk protect require auth accidentally

Copy link
Contributor

@kyegupov kyegupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a fix (would be easier to read than the revert); if it works locally - please merge.

@lili2311 lili2311 changed the title Revert "chore: refactor snyk missing api token" Fix: revert refactor snyk missing api token Jun 3, 2019
@lili2311 lili2311 self-assigned this Jun 3, 2019
@lili2311 lili2311 merged commit fea5ae6 into master Jun 3, 2019
@lili2311 lili2311 deleted the fix/revert-bad-refactor branch June 3, 2019 12:22
@orsagie orsagie restored the fix/revert-bad-refactor branch June 3, 2019 12:38
@lili2311 lili2311 deleted the fix/revert-bad-refactor branch June 3, 2019 12:38
@orsagie orsagie restored the fix/revert-bad-refactor branch June 3, 2019 12:39
@snyksec
Copy link

snyksec commented Jun 3, 2019

🎉 This PR is included in version 1.171.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants