fix: protect failing due to missing auth #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please include the original commit in this PR as well? |
orsagie
force-pushed
the
fix/api_token_refactor
branch
2 times, most recently
from
44b351d
to
892538c
Compare
dkontorovskyy
force-pushed
the
fix/api_token_refactor
branch
2 times, most recently
from
a8c8439
to
d5de27a
Compare
lili2311
requested changes
Jun 3, 2019
dkontorovskyy
force-pushed
the
fix/api_token_refactor
branch
2 times, most recently
from
2cb3c29
to
66746dd
Compare
|
|
lili2311
reviewed
Jun 3, 2019
kyegupov
reviewed
Jun 3, 2019
dkontorovskyy
force-pushed
the
fix/api_token_refactor
branch
from
83926dd
to
33438a9
Compare
kyegupov
approved these changes
Jun 4, 2019
dkontorovskyy
force-pushed
the
fix/api_token_refactor
branch
from
468c79d
to
ad29871
Compare
lili2311
approved these changes
Jun 4, 2019
|
tested locally:
|
|
🎉 This PR is included in version 1.172.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 12, 2021
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue where
snyk protectfails due to missing api token.The change was reverted here: #549
This change fixes the underlying issue, and adds a test to make sure protect auth behaviour is as expected.
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots
Additional questions