Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge v0.7 into main #429

Merged
merged 61 commits into from
Apr 13, 2021
Merged

merge v0.7 into main #429

merged 61 commits into from
Apr 13, 2021

Conversation

sundowndev
Copy link
Contributor

@sundowndev sundowndev commented Apr 13, 2021

Merge changes of version 0.7.1 into the main branch.


Changelog

⚠️ DEPRECATION NOTICE: this release contains breaking changes and upgrading may cause unexpected behavior.

Here's what you should know before upgrading:

  • Keyword "deleted" was renamed to "missing" in text and JSON output
  • Keyword "drifted" was renamed to "changed" in text and JSON output
  • CLI flag --error-reporting was renamed to --send-crash-report
  • To avoid unnecessary noise in the scan result, default AWS resources, like the service-linked role associated to your account will now be ignored by default. You can use the --strict flag to disable this behavior

🚀 Features

🐛 Bug Fixes

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #429 (1924900) into main (90da652) will increase coverage by 0.25%.
The diff coverage is 91.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   70.48%   70.73%   +0.25%     
==========================================
  Files         282      284       +2     
  Lines        6284     6396     +112     
==========================================
+ Hits         4429     4524      +95     
- Misses       1490     1504      +14     
- Partials      365      368       +3     
Impacted Files Coverage Δ
pkg/resource/aws/aws_db_instance.go 66.66% <ø> (ø)
pkg/resource/aws/aws_instance.go 100.00% <ø> (ø)
pkg/resource/aws/aws_lambda_function.go 66.66% <ø> (ø)
pkg/resource/aws/aws_route53_record.go 66.66% <ø> (ø)
pkg/resource/aws/aws_route53_record_ext.go 62.50% <0.00%> (-20.84%) ⬇️
pkg/resource/aws/aws_iam_policy_attachment_ext.go 50.00% <50.00%> (ø)
pkg/cmd/scan.go 82.30% <85.71%> (+0.40%) ⬆️
pkg/analyser/analyzer.go 94.59% <93.75%> (-0.15%) ⬇️
pkg/analyser/analysis.go 97.40% <100.00%> (+0.43%) ⬆️
pkg/cmd/driftctl.go 79.59% <100.00%> (ø)
... and 11 more

@sundowndev sundowndev marked this pull request as ready for review April 13, 2021 12:01
@sundowndev sundowndev requested a review from a team as a code owner April 13, 2021 12:01
sundowndev and others added 27 commits April 13, 2021 14:01
…canned and hide animation character when progress bar end
following code review feedback. pkg/middlewares/aws_route_table_expander.go
- Ignore directory (size <= 0) when listing bucket object
- Add test for empty directory
@@ -3,7 +3,7 @@
"total_resources": 6,
"total_drifted": 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

total_changed

@@ -64,7 +64,9 @@ func runTest(t *testing.T, cases TestCases) {
c.mocks(resourceFactory)
}

driftctl := pkg.NewDriftCTL(remoteSupplier, stateSupplier, filter, testAlerter, resourceFactory)
driftctl := pkg.NewDriftCTL(remoteSupplier, stateSupplier, testAlerter, resourceFactory, &pkg.ScanOptions{
Filter: filter,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sundowndev Just a reminder to add a test of strict mode there (do not do this in this PR)

@eliecharra eliecharra merged commit 8c2a95d into main Apr 13, 2021
@eliecharra eliecharra deleted the v0.7 branch April 13, 2021 15:16
@eliecharra eliecharra added the kind/maintenance Refactoring or changes to the workspace label Apr 13, 2021
@eliecharra eliecharra changed the title Driftctl v0.7.1 merge v0.7 into main Apr 13, 2021
@sundowndev sundowndev restored the v0.7 branch April 15, 2021 08:41
@sundowndev sundowndev removed the kind/maintenance Refactoring or changes to the workspace label Apr 30, 2021
@sundowndev-snyk sundowndev-snyk deleted the v0.7 branch June 8, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

directory are listed when we use s3 as a backend for states
4 participants