-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge v0.7 into main #429
merge v0.7 into main #429
Conversation
Codecov Report
@@ Coverage Diff @@
## main #429 +/- ##
==========================================
+ Coverage 70.48% 70.73% +0.25%
==========================================
Files 282 284 +2
Lines 6284 6396 +112
==========================================
+ Hits 4429 4524 +95
- Misses 1490 1504 +14
- Partials 365 368 +3
|
…ar to driftctl-docs
…canned and hide animation character when progress bar end
…rash when it's null
following code review feedback. pkg/middlewares/aws_route_table_expander.go
isDefaultRecord in pkg/middlewares/route53_record.go
@@ -3,7 +3,7 @@ | |||
"total_resources": 6, | |||
"total_drifted": 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
total_changed
@@ -64,7 +64,9 @@ func runTest(t *testing.T, cases TestCases) { | |||
c.mocks(resourceFactory) | |||
} | |||
|
|||
driftctl := pkg.NewDriftCTL(remoteSupplier, stateSupplier, filter, testAlerter, resourceFactory) | |||
driftctl := pkg.NewDriftCTL(remoteSupplier, stateSupplier, testAlerter, resourceFactory, &pkg.ScanOptions{ | |||
Filter: filter, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sundowndev Just a reminder to add a test of strict mode there (do not do this in this PR)
Merge changes of version 0.7.1 into the main branch.
Changelog
Here's what you should know before upgrading:
--error-reporting
was renamed to--send-crash-report
--strict
flag to disable this behavior🚀 Features
🐛 Bug Fixes