Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename total_drifted to total_changed in JSON testdata #432

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

sundowndev
Copy link
Contributor

@sundowndev sundowndev commented Apr 13, 2021

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #429 (comment)
❓ Documentation no

Description

Fix a typo in JSON testdata. The tests are still passing because that field overridden by the number of element in the differences property.

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #432 (b93ed4e) into main (8c2a95d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   70.73%   70.73%           
=======================================
  Files         284      284           
  Lines        6396     6396           
=======================================
  Hits         4524     4524           
  Misses       1504     1504           
  Partials      368      368           

@sundowndev sundowndev added the kind/maintenance Refactoring or changes to the workspace label Apr 13, 2021
@sundowndev sundowndev marked this pull request as ready for review April 13, 2021 16:15
@sundowndev sundowndev requested a review from a team as a code owner April 13, 2021 16:15
@sundowndev sundowndev merged commit a7dd193 into main Apr 14, 2021
@sundowndev sundowndev deleted the fix/jsonTestData branch April 14, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants