Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing master to perf_coll_fw_enhance #683

Merged
merged 7 commits into from
Sep 3, 2021
Merged

Conversation

NajmudheenCT
Copy link
Member

What this PR does / why we need it:
back merge latest merges from master to feature branch
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #683 (75023fe) into perf_coll_fw_enhance (baa386e) will increase coverage by 0.83%.
The diff coverage is 82.72%.

@@                   Coverage Diff                    @@
##           perf_coll_fw_enhance     #683      +/-   ##
========================================================
+ Coverage                 70.15%   70.98%   +0.83%     
========================================================
  Files                       156      163       +7     
  Lines                     14801    15546     +745     
  Branches                   1822     1908      +86     
========================================================
+ Hits                      10384    11036     +652     
- Misses                     3816     3889      +73     
- Partials                    601      621      +20     
Impacted Files Coverage Δ
delfin/api/v1/port_groups.py 42.85% <0.00%> (-14.29%) ⬇️
delfin/api/v1/storage_host_groups.py 42.85% <0.00%> (-14.29%) ⬇️
delfin/api/v1/volume_groups.py 42.85% <0.00%> (-14.29%) ⬇️
delfin/db/sqlalchemy/api.py 71.85% <ø> (+2.77%) ⬆️
delfin/drivers/huawei/oceanstor/oceanstor.py 78.19% <76.28%> (-1.25%) ⬇️
delfin/drivers/huawei/oceanstor/rest_client.py 75.98% <95.55%> (+2.27%) ⬆️
delfin/drivers/fake_storage/__init__.py 95.14% <96.07%> (+4.49%) ⬆️
delfin/common/constants.py 100.00% <100.00%> (ø)
delfin/drivers/huawei/oceanstor/consts.py 100.00% <100.00%> (ø)
delfin/task_manager/tasks/resources.py 81.93% <100.00%> (+8.11%) ⬆️
... and 22 more

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NajmudheenCT NajmudheenCT merged commit a88486e into perf_coll_fw_enhance Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants