Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing perf_coll_fw_enhance feature branch to master #692

Merged
merged 12 commits into from
Sep 14, 2021

Conversation

NajmudheenCT
Copy link
Member

What this PR does / why we need it:
Merge feature branch to master which has

  • Localised job scheduling
  • Centralised job distribution

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #669 #670

Special notes for your reviewer:
PRs has been reviewed and tested in feature branch
below are the summary of different scenarios tested with this branch

  1. Storage registration
  2. Storage deletion
  3. Worker node up
  4. worker node down
  5. Leader node up
  6. Leader node down
  7. Collection failure handling
  8. Task restart
  9. Leader switch

Detailed TCs are available here

Release note:

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #692 (2c8cee5) into master (cdbaf38) will decrease coverage by 0.24%.
The diff coverage is 59.76%.

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
- Coverage   70.97%   70.72%   -0.25%     
==========================================
  Files         157      161       +4     
  Lines       15347    15560     +213     
  Branches     1928     1934       +6     
==========================================
+ Hits        10892    11005     +113     
- Misses       3814     3906      +92     
- Partials      641      649       +8     
Impacted Files Coverage Δ
delfin/cmd/task.py 0.00% <0.00%> (ø)
delfin/common/config.py 95.00% <ø> (ø)
...in/leader_election/distributor/perf_job_manager.py 0.00% <0.00%> (ø)
delfin/leader_election/factory.py 43.75% <0.00%> (-2.92%) ⬇️
delfin/task_manager/manager.py 0.00% <ø> (ø)
delfin/task_manager/metrics_manager.py 0.00% <0.00%> (ø)
delfin/task_manager/tasks/telemetry.py 71.42% <ø> (+0.59%) ⬆️
delfin/task_manager/metrics_rpcapi.py 50.00% <50.00%> (ø)
delfin/task_manager/scheduler/schedule_manager.py 66.66% <57.14%> (+11.11%) ⬆️
delfin/task_manager/perf_job_controller.py 61.29% <61.29%> (ø)
... and 19 more

@sushanthakumar
Copy link
Collaborator

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumarashit kumarashit merged commit e73f251 into master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create job distributor for metric collection tasks
5 participants