Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macro_san storage serial_number #954

Closed
wants to merge 2 commits into from

Conversation

zhilong-xu
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #954 (1a089db) into master (4ba8e59) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #954      +/-   ##
==========================================
- Coverage   71.35%   71.34%   -0.02%     
==========================================
  Files         187      187              
  Lines       23067    23067              
  Branches     3508     3508              
==========================================
- Hits        16460    16457       -3     
- Misses       5491     5492       +1     
- Partials     1116     1118       +2     
Impacted Files Coverage Δ
delfin/drivers/macro_san/ms/ms_handler.py 65.08% <50.00%> (ø)
delfin/drivers/fake_storage/__init__.py 93.90% <0.00%> (-0.77%) ⬇️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sushanthakumar sushanthakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v
Copy link
Collaborator

This commit is merged in PR: #959

@joseph-v joseph-v closed this Dec 19, 2022
@zhilong-xu zhilong-xu deleted the macro_san branch December 19, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants