Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit storage serial_number #959

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Conversation

amanr032
Copy link

What this PR does / why we need it:
Modification of Storage Serial Number

Which issue this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Release note:

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #959 (32dd616) into master (6ef9d9f) will decrease coverage by 0.80%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
- Coverage   71.37%   70.56%   -0.81%     
==========================================
  Files         187      192       +5     
  Lines       23071    23205     +134     
  Branches     3510     3568      +58     
==========================================
- Hits        16466    16374      -92     
- Misses       5490     5712     +222     
- Partials     1115     1119       +4     
Impacted Files Coverage Δ
delfin/drivers/macro_san/ms/ms_handler.py 64.58% <50.00%> (-0.51%) ⬇️
delfin/leader_election/interface.py 48.00% <0.00%> (-11.38%) ⬇️
delfin/drivers/driver.py 57.81% <0.00%> (-4.69%) ⬇️
delfin/wsgi/common.py 64.28% <0.00%> (-3.46%) ⬇️
delfin/drivers/utils/tools.py 62.72% <0.00%> (-1.93%) ⬇️
delfin/api/validation/validators.py 44.35% <0.00%> (-1.74%) ⬇️
delfin/task_manager/tasks/telemetry.py 70.00% <0.00%> (-1.43%) ⬇️
delfin/cryptor.py 90.90% <0.00%> (-1.40%) ⬇️
delfin/api/v1/alerts.py 74.54% <0.00%> (-1.32%) ⬇️
...in/drivers/netapp/dataontap/performance_handler.py 79.59% <0.00%> (-1.18%) ⬇️
... and 60 more

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
CI failure is tracked in
#923

Copy link
Collaborator

@sushanthakumar sushanthakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sushanthakumar sushanthakumar merged commit f2553bd into sodafoundation:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants