Raise an error if spec has unknown columns #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vankesteren
approved these changes
Jul 5, 2023
| @@ -117,6 +117,9 @@ def from_dataframe(cls, | |||
| else: | |||
| spec = deepcopy(spec) | |||
|
|
|||
| if set(list(spec)) - set(df.columns): | |||
There was a problem hiding this comment.
This line looks great, set difference by just instantiating set objects
metasynth/dataset.py
Outdated
Comment on lines
121
to
122
| raise ValueError("Specifications found for column that were not found in the " | ||
| f"dataset itself: {set(list(spec)) - set(df.columns)}") |
There was a problem hiding this comment.
@Samuwhale do you have a suggestion for a better error message here? I am wondering if this is immediately understandable, but I'm finding it hard to decide on a better error message.
I checked what tidyverse does when loading a csv with a spec with a column that could not be found; it displays a warning (not an error) and it's the following message:
Warning message:
The following named parsers don't match the column names: Pid
I think that is kind of worse so maybe our message is ok 😃
There was a problem hiding this comment.
Feel free to merge and create a new issue out of this comment
| @@ -92,6 +92,10 @@ def check_dataset(dataset): | |||
| print(name, dataset.descriptions[name]) | |||
| assert dataset.descriptions[name] == name | |||
|
|
|||
| # Check whether non-columns raise an error | |||
| with pytest.raises(ValueError): | |||
| dataset = MetaDataset.from_dataframe(df, spec={"unicorn": {"prop_missing": 0.5}}) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104