Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an error if spec has unknown columns #112

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Raise an error if spec has unknown columns #112

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bf24ff
Raise an error if spec has unknown columns
qubixes Jul 4, 2023
3cf5526
Improve error message
qubixes Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions metasynth/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ def from_dataframe(cls,
else:
spec = deepcopy(spec)

if set(list(spec)) - set(df.columns):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks great, set difference by just instantiating set objects

raise ValueError("Specifications found for column that were not found in the "
f"dataset itself: {set(list(spec)) - set(df.columns)}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Samuwhale do you have a suggestion for a better error message here? I am wondering if this is immediately understandable, but I'm finding it hard to decide on a better error message.

I checked what tidyverse does when loading a csv with a spec with a column that could not be found; it displays a warning (not an error) and it's the following message:

Warning message:                                                                     
The following named parsers don't match the column names: Pid

I think that is kind of worse so maybe our message is ok 😃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge and create a new issue out of this comment

all_vars = []
for col_name in df.columns:
series = df[col_name]
Expand Down
4 changes: 4 additions & 0 deletions tests/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ def check_dataset(dataset):
print(name, dataset.descriptions[name])
assert dataset.descriptions[name] == name

# Check whether non-columns raise an error
with pytest.raises(ValueError):
dataset = MetaDataset.from_dataframe(df, spec={"unicorn": {"prop_missing": 0.5}})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄



def test_distributions(tmp_path):
tmp_fp = tmp_path / "tmp.json"
Expand Down