Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge inject mock #1237

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Conversation

HzjNeverStop
Copy link
Contributor

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #1237 (565d6a7) into 3.x (9c9a0b9) will increase coverage by 0.55%.
Report is 2 commits behind head on 3.x.
The diff coverage is 84.30%.

@@             Coverage Diff              @@
##                3.x    #1237      +/-   ##
============================================
+ Coverage     71.83%   72.38%   +0.55%     
- Complexity     1864     1979     +115     
============================================
  Files           260      269       +9     
  Lines          7470     7812     +342     
  Branches        943      996      +53     
============================================
+ Hits           5366     5655     +289     
- Misses         1623     1650      +27     
- Partials        481      507      +26     
Files Changed Coverage Δ
.../com/alipay/sofa/runtime/spi/binding/Contract.java 0.00% <0.00%> (ø)
...a/runtime/invoke/DynamicJvmServiceProxyFinder.java 38.02% <50.00%> (ø)
...a/test/mock/injector/definition/SpyDefinition.java 55.26% <55.26%> (ø)
...sofa/test/mock/injector/definition/Definition.java 72.72% <72.72%> (ø)
.../test/mock/injector/definition/MockDefinition.java 83.33% <83.33%> (ø)
.../mock/injector/definition/QualifierDefinition.java 87.50% <87.50%> (ø)
...ck/injector/InjectorMockTestExecutionListener.java 88.63% <88.63%> (ø)
...t/mock/injector/resolver/BeanInjectorResolver.java 92.77% <92.77%> (ø)
.../test/mock/injector/resolver/BeanInjectorStub.java 94.11% <94.11%> (ø)
...fa/runtime/service/component/AbstractContract.java 66.66% <100.00%> (+1.96%) ⬆️
... and 1 more

... and 2 files with indirect coverage changes

Copy link
Contributor

@crazysaltfish crazysaltfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit 1406c1b into sofastack:3.x Aug 25, 2023
4 checks passed
@HzjNeverStop HzjNeverStop deleted the merge_inject_mock branch August 30, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants