feat: Added side-effect-free stubbing framework for SOFABoot applications #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2023 20:49
…ions With the support of @SofaMockBeanFor and @SofaSpyBeanFor annotations, you can easily mock/spy external dependencies when writing integration tests. More importantly, these annotations does not produce any side-effects, which means that the Spring ApplicationContext can be efficiently cached and reused among different test cases, thus greatly reduce test cost.
|
Hi @Peng-YM, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
|
This resolves #1172 |
...core/test-sofa-boot/src/main/java/com/alipay/sofa/testing/SofaBootTestAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...core/test-sofa-boot/src/main/java/com/alipay/sofa/testing/SofaBootTestAutoConfiguration.java
Outdated
Show resolved
Hide resolved
sofa-boot-project/sofa-boot-core/test-sofa-boot/src/main/resources/META-INF/spring.factories
Outdated
Show resolved
Hide resolved
sofa-boot-project/sofa-boot-core/test-sofa-boot/src/main/resources/META-INF/spring.factories
Outdated
Show resolved
Hide resolved
...re/test-sofa-boot/src/main/java/com/alipay/sofa/testing/model/definition/StubDefinition.java
Outdated
Show resolved
Hide resolved
...sofa-boot-core/test-sofa-boot/src/main/java/com/alipay/sofa/testing/model/stub/SofaStub.java
Outdated
Show resolved
Hide resolved
...core/test-sofa-boot/src/main/java/com/alipay/sofa/testing/SofaBootTestExecutionListener.java
Outdated
Show resolved
Hide resolved
...core/test-sofa-boot/src/main/java/com/alipay/sofa/testing/SofaBootTestAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/alipay/sofa/smoke/tests/integration/test/AnotherExternalServiceClient.java
Outdated
Show resolved
Hide resolved
...ration-test/src/test/java/com/alipay/sofa/smoke/tests/integration/test/MockSofaBeanTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/alipay/sofa/smoke/tests/integration/test/base/SofaBootTestApplication.java
Outdated
Show resolved
Hide resolved
Co-authored-by: 致节 <hzj266771@antgroup.com>
added 7 commits
August 14, 2023 13:46
...nfigure/src/main/java/com/alipay/sofa/boot/autoconfigure/test/SofaTestAutoConfiguration.java
Outdated
Show resolved
Hide resolved
Major refactor and improvements
Codecov Report
@@ Coverage Diff @@
## master #1224 +/- ##
============================================
- Coverage 84.51% 84.13% -0.39%
- Complexity 2711 2864 +153
============================================
Files 308 323 +15
Lines 8837 9316 +479
Branches 1049 1113 +64
============================================
+ Hits 7469 7838 +369
- Misses 898 973 +75
- Partials 470 505 +35
|
HzjNeverStop
approved these changes
Aug 25, 2023
| @@ -25,6 +25,22 @@ | |||
| <groupId>org.springframework.boot</groupId> | |||
| <artifactId>spring-boot-starter-test</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
runtime-sofa-boot 和 isle-sofa-boot 设置 true，test 功能和这两个不强耦合
commons-lang3 依赖移除，替换为 spring 自己的工具类
lombok 依赖移除，框架代码不能依赖动态代码生成，需要直接编写相应代码
sofa-boot-tests/pom.xml
Outdated
| @@ -22,6 +22,7 @@ | |||
| <modules> | |||
| <module>sofa-boot-smoke-tests</module> | |||
| <module>sofa-boot-jacoco-report</module> | |||
| <module>sofa-boot-smoke-tests/sofa-boot-smoke-tests-integration-test</module> | |||
There was a problem hiding this comment.
sofa-boot-smoke-tests-integration-test 应该是 sofa-boot-smoke-tests 的子模块，而不是 sofa-boot-tests
| <groupId>com.alipay.sofa</groupId> | ||
| <artifactId>runtime-sofa-boot-starter</artifactId> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
只需要保留 runtime-sofa-boot-starter 依赖，和 test-sofa-boot-starter 依赖
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.alipay.sofa.testing; |
There was a problem hiding this comment.
包名统一修改为 com.alipay.sofa.test，和spring的风格保持一致，用 test 而不是 testing
HzjNeverStop
pushed a commit
to HzjNeverStop/sofa-boot
that referenced
this pull request
Aug 25, 2023
HzjNeverStop
pushed a commit
to HzjNeverStop/sofa-boot
that referenced
this pull request
Aug 25, 2023
HzjNeverStop
added a commit
that referenced
this pull request
Aug 25, 2023
* cherrypick:Added side-effect-free stubbing framework for SOFABoot applications #1224 --------- Co-authored-by: 致节 <hzj266771@antgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the support of @SofaMockBeanFor and @SofaSpyBeanFor annotations, you can easily mock/spy external dependencies when writing integration tests. More importantly, these annotations does not produce any side-effects, which means that the Spring ApplicationContext can be efficiently cached and reused among different test cases, thus greatly reduce test cost.