Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid SofaConfigSourceSupportListener duplicate register configs #1246

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Avoid SofaConfigSourceSupportListener duplicate register configs #1246

merged 1 commit into from
Sep 20, 2023

Conversation

HzjNeverStop
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.06% ⚠️

Comparison is base (b274315) 84.15% compared to head (04f0713) 84.10%.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1246      +/-   ##
============================================
- Coverage     84.15%   84.10%   -0.06%     
+ Complexity     2865     2861       -4     
============================================
  Files           323      323              
  Lines          9314     9316       +2     
  Branches       1113     1113              
============================================
- Hits           7838     7835       -3     
- Misses          973      974       +1     
- Partials        503      507       +4
Files Changed Coverage Δ
...boot/listener/SofaConfigSourceSupportListener.java 91.66% <66.66%> (-8.34%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crazysaltfish
crazysaltfish approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@crazysaltfish crazysaltfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit 18cd99e into sofastack:master Sep 20, 2023
1 of 3 checks passed
HzjNeverStop added a commit to HzjNeverStop/sofa-boot that referenced this pull request Sep 25, 2023
@HzjNeverStop
avoid SofaConfigSourceSupportListener duplicate register configs (sof…
d653195 
…astack#1246)
HzjNeverStop added a commit that referenced this pull request Sep 28, 2023
@HzjNeverStop
Merge #1246 (#1251)
d03eeea 
* init interface class canonical name to avoid multi reflection

* update 3.21.0-SNAPSHOT

* avoid SofaConfigSourceSupportListener duplicate register configs (#1246)

* format

---------

Co-authored-by: 致节 <hzj266771@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazysaltfish crazysaltfish crazysaltfish approved these changes

Assignees
No one assigned
Labels
cla:yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HzjNeverStop @crazysaltfish