Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #1246 #1251

Merged
merged 7 commits into from
Sep 28, 2023
Merged

Merge #1246 #1251

merged 7 commits into from
Sep 28, 2023

Conversation

HzjNeverStop
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.01% ⚠️

Comparison is base (3aa6a45) 72.38% compared to head (4ad79fd) 72.37%.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.x    #1251      +/-   ##
============================================
- Coverage     72.38%   72.37%   -0.01%     
- Complexity     1978     1979       +1     
============================================
  Files           269      269              
  Lines          7810     7813       +3     
  Branches        996      996              
============================================
+ Hits           5653     5655       +2     
  Misses         1649     1649              
- Partials        508      509       +1     
Files Changed Coverage Δ
...boot/listener/SofaConfigSourceSupportListener.java 91.66% <88.88%> (-8.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@crazysaltfish crazysaltfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit d03eeea into sofastack:3.x Sep 28, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants