release rpc version 5.13.2 #1455
Conversation
WalkthroughThe changes in this pull request involve updates to versioning across several files. The Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (4)
- all/pom.xml (1 hunks)
- bom/pom.xml (1 hunks)
- core/api/src/main/java/com/alipay/sofa/rpc/common/Version.java (1 hunks)
- pom.xml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- core/api/src/main/java/com/alipay/sofa/rpc/common/Version.java
🧰 Additional context used
🔇 Additional comments (5)
bom/pom.xml (3)
13-13: Version updated from snapshot to releaseThe
<revision>property has been updated from5.13.2-SNAPSHOTto5.13.2, indicating a transition from a development snapshot to a stable release version. This change aligns with the PR objective of releasing RPC version 5.13.2.
Line range hint
1-669: No additional changes requiredI've reviewed the entire file, and the update to the
<revision>property is the only change needed for this release. The use of${revision}in the<version>tag ensures that the project version is updated correctly throughout the file. No other modifications are necessary in this BOM file for the 5.13.2 release.
Line range hint
1-669: LGTM: File changes approved for 5.13.2 releaseThe changes in this file are appropriate and sufficient for the release of SOFA-RPC version 5.13.2. The update from
5.13.2-SNAPSHOTto5.13.2in the<revision>property correctly reflects the transition from a development snapshot to a stable release version. No other changes were necessary in this BOM file. The modifications align with the PR objectives and the AI-generated summary.all/pom.xml (2)
Line range hint
1-1000: Overall, the POM file looks good.The version update is the only change in this file, and it correctly reflects the release of RPC version 5.13.2. The rest of the file remains unchanged, which is appropriate for this type of version update. The extensive configuration in the file appears to be well-maintained and doesn't require any modifications as a result of this version change.
9-9: Version update looks good.The version has been correctly updated from a snapshot to a release version, which aligns with the PR objective of releasing RPC version 5.13.2.
Let's verify that all SOFA RPC module dependencies are using
${project.version}to ensure consistency:If this script returns no output, it means all SOFA RPC module dependencies are correctly using
${project.version}.
| @@ -77,7 +77,7 @@ | |||
|
|
|||
| <properties> | |||
| <!-- Build args --> | |||
| <revision>5.13.2-SNAPSHOT</revision> | |||
| <revision>5.13.2</revision> | |||
There was a problem hiding this comment.
💡 Codebase verification
Inconsistencies Found in Versioning
The following pom.xml files do not have the <revision>5.13.2</revision> set, which may lead to versioning inconsistencies across the project:
- all/pom.xml
- bootstrap/bootstrap-api/pom.xml
- bootstrap/bootstrap-bolt/pom.xml
- bootstrap/bootstrap-dubbo/pom.xml
- bootstrap/bootstrap-http/pom.xml
- bootstrap/bootstrap-rest/pom.xml
- bootstrap/bootstrap-triple/pom.xml
- bootstrap/pom.xml
- codec/codec-api/pom.xml
- codec/codec-jackson/pom.xml
- codec/codec-msgpack/pom.xml
- codec/codec-protobuf/pom.xml
- codec/codec-protostuff/pom.xml
- codec/codec-sofa-fury/pom.xml
- codec/codec-sofa-hessian/pom.xml
- codec/pom.xml
- compiler/pom.xml
- config/config-apollo/pom.xml
- config/pom.xml
- core/api/pom.xml
- core/api-compatible/pom.xml
- core/common/pom.xml
- core/exception/pom.xml
- core/pom.xml
- core-impl/client/pom.xml
- core-impl/filter/pom.xml
- core-impl/log/pom.xml
- core-impl/pom.xml
- core-impl/proxy/pom.xml
- core-impl/transport/pom.xml
- doc-swagger/pom.xml
- example/pom.xml
- fault/fault-hystrix/pom.xml
- fault/fault-tolerance/pom.xml
- fault/pom.xml
- log-common-tools/pom.xml
- metrics/metrics-micrometer/pom.xml
- metrics/metrics-prometheus/pom.xml
- metrics/pom.xml
- registry/config-apollo/pom.xml
- registry/pom.xml
- registry/registry-consul/pom.xml
- registry/registry-kubernetes/pom.xml
- registry/registry-local/pom.xml
- registry/registry-mesh/pom.xml
- registry/registry-multicast/pom.xml
- registry/registry-nacos/pom.xml
- registry/registry-polaris/pom.xml
- registry/registry-sofa/pom.xml
- registry/registry-zk/pom.xml
- remoting/pom.xml
- remoting/remoting-bolt/pom.xml
- remoting/remoting-http/pom.xml
- remoting/remoting-resteasy/pom.xml
- remoting/remoting-triple/pom.xml
- test/pom.xml
- test/test-common/pom.xml
- test/test-integration/pom.xml
- test/test-integration-3rd/pom.xml
- tracer/pom.xml
- tracer/tracer-opentracing/pom.xml
- tracer/tracer-opentracing-resteasy/pom.xml
- tracer/tracer-opentracing-triple/pom.xml
Please update these files to ensure the version 5.13.2 is consistently applied across the project.
🔗 Analysis chain
LGTM: Version update for release 5.13.2
The change from 5.13.2-SNAPSHOT to 5.13.2 in the <revision> property indicates that this commit is preparing the project for the 5.13.2 release. This update will propagate to all modules and dependencies that reference the ${revision} property, ensuring consistent versioning across the project.
This change aligns with the pull request title "release rpc version 5.13.2" and follows the standard Maven practice for transitioning from a development (SNAPSHOT) version to a release version.
To ensure this version update is consistent across the project, please run the following command:
This will help identify any inconsistencies in version numbers across the project's POM files.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify that the version 5.13.2 is consistently used across the project
grep -R --include="pom.xml" "<version>5.13.2</version>" .
grep -R --include="pom.xml" "<revision>5.13.2</revision>" .
Length of output: 257
Script:
#!/bin/bash
# Find all pom.xml files where <revision> is not set to 5.13.2
fd pom.xml | xargs grep -L '<revision>5.13.2</revision>'
Length of output: 1753
release rpc version 5.13.2
Summary by CodeRabbit
New Features
Bug Fixes