Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release rpc version 5.13.2 #1455

Merged
merged 1 commit into from
Oct 17, 2024
Merged

release rpc version 5.13.2 #1455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion all/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>com.alipay.sofa</groupId>
<artifactId>sofa-rpc-all</artifactId>
<version>5.13.2-SNAPSHOT</version>
<version>5.13.2</version>


<name>${project.groupId}:${project.artifactId}</name>
Expand Down
2 changes: 1 addition & 1 deletion bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<packaging>pom</packaging>

<properties>
<revision>5.13.2-SNAPSHOT</revision>
<revision>5.13.2</revision>
<javassist.version>3.29.2-GA</javassist.version>
<bytebuddy.version>1.9.8</bytebuddy.version>
<netty.version>4.1.77.Final</netty.version>
Expand Down
2 changes: 1 addition & 1 deletion core/api/src/main/java/com/alipay/sofa/rpc/common/Version.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@ public final class Version {
/**
* 当前Build版本，每次发布修改
*/
public static final String BUILD_VERSION = "5.13.2_20240922142359";
public static final String BUILD_VERSION = "5.13.2_20241016193119";

}
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@

<properties>
<!-- Build args -->
<revision>5.13.2-SNAPSHOT</revision>
<revision>5.13.2</revision>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Inconsistencies Found in Versioning

The following pom.xml files do not have the <revision>5.13.2</revision> set, which may lead to versioning inconsistencies across the project:

  • all/pom.xml
  • bootstrap/bootstrap-api/pom.xml
  • bootstrap/bootstrap-bolt/pom.xml
  • bootstrap/bootstrap-dubbo/pom.xml
  • bootstrap/bootstrap-http/pom.xml
  • bootstrap/bootstrap-rest/pom.xml
  • bootstrap/bootstrap-triple/pom.xml
  • bootstrap/pom.xml
  • codec/codec-api/pom.xml
  • codec/codec-jackson/pom.xml
  • codec/codec-msgpack/pom.xml
  • codec/codec-protobuf/pom.xml
  • codec/codec-protostuff/pom.xml
  • codec/codec-sofa-fury/pom.xml
  • codec/codec-sofa-hessian/pom.xml
  • codec/pom.xml
  • compiler/pom.xml
  • config/config-apollo/pom.xml
  • config/pom.xml
  • core/api/pom.xml
  • core/api-compatible/pom.xml
  • core/common/pom.xml
  • core/exception/pom.xml
  • core/pom.xml
  • core-impl/client/pom.xml
  • core-impl/filter/pom.xml
  • core-impl/log/pom.xml
  • core-impl/pom.xml
  • core-impl/proxy/pom.xml
  • core-impl/transport/pom.xml
  • doc-swagger/pom.xml
  • example/pom.xml
  • fault/fault-hystrix/pom.xml
  • fault/fault-tolerance/pom.xml
  • fault/pom.xml
  • log-common-tools/pom.xml
  • metrics/metrics-micrometer/pom.xml
  • metrics/metrics-prometheus/pom.xml
  • metrics/pom.xml
  • registry/config-apollo/pom.xml
  • registry/pom.xml
  • registry/registry-consul/pom.xml
  • registry/registry-kubernetes/pom.xml
  • registry/registry-local/pom.xml
  • registry/registry-mesh/pom.xml
  • registry/registry-multicast/pom.xml
  • registry/registry-nacos/pom.xml
  • registry/registry-polaris/pom.xml
  • registry/registry-sofa/pom.xml
  • registry/registry-zk/pom.xml
  • remoting/pom.xml
  • remoting/remoting-bolt/pom.xml
  • remoting/remoting-http/pom.xml
  • remoting/remoting-resteasy/pom.xml
  • remoting/remoting-triple/pom.xml
  • test/pom.xml
  • test/test-common/pom.xml
  • test/test-integration/pom.xml
  • test/test-integration-3rd/pom.xml
  • tracer/pom.xml
  • tracer/tracer-opentracing/pom.xml
  • tracer/tracer-opentracing-resteasy/pom.xml
  • tracer/tracer-opentracing-triple/pom.xml

Please update these files to ensure the version 5.13.2 is consistently applied across the project.

🔗 Analysis chain

LGTM: Version update for release 5.13.2

The change from 5.13.2-SNAPSHOT to 5.13.2 in the <revision> property indicates that this commit is preparing the project for the 5.13.2 release. This update will propagate to all modules and dependencies that reference the ${revision} property, ensuring consistent versioning across the project.

This change aligns with the pull request title "release rpc version 5.13.2" and follows the standard Maven practice for transitioning from a development (SNAPSHOT) version to a release version.

To ensure this version update is consistent across the project, please run the following command:

This will help identify any inconsistencies in version numbers across the project's POM files.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify that the version 5.13.2 is consistently used across the project
grep -R --include="pom.xml" "<version>5.13.2</version>" .
grep -R --include="pom.xml" "<revision>5.13.2</revision>" .

Length of output: 257

Script:

#!/bin/bash
# Find all pom.xml files where <revision> is not set to 5.13.2
fd pom.xml | xargs grep -L '<revision>5.13.2</revision>'

Length of output: 1753

<jmh.version>1.33</jmh.version>
<module.install.skip>true</module.install.skip>
<module.deploy.skip>true</module.deploy.skip>
Expand Down
Loading