Redesigning protostar.toml 6 — Version checker

[kasperski95]

Currently, protostar_version is not properly handled by Protostar. It shouldn't be used to detect the version of the configuration file (v1, v2), but help a development team that uses Protostar to use compatible versions.

Use case

Let's say we introduce a new cheatcode in Protostar v0.5. Alice upgraded Protostar and uses Protostar v0.5. Bob uses Protostar v0.4. Alice uses the new cheatcode and integrates her code with the mainline. Bob pulls the mainline and runs the code that uses the new cheatcode.

Note:

We should bump the minor (not micro) if forward compatibility is no preserved (e.g. new cheatcode).

Current behavior

Protostar crashes for Bob.

Expected behavior

1. Protostar tells Alice to update the declared version in the configuration file.
2. Protostar tells Bob to upgrade Protostar.

[codecov]

Codecov Report

Base: 85.79% // Head: 85.87% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (237988d) compared to base (81b4ac7).
Patch coverage: 96.25% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
+ Coverage   85.79%   85.87%   +0.07%     
==========================================
  Files         253      258       +5     
  Lines        8328     8436     +108     
==========================================
+ Hits         7145     7244      +99     
- Misses       1183     1192       +9     

Impacted Files	Coverage Δ
...lf/protostar_compatibility_with_project_checker.py	90.90% <90.90%> (ø)
protostar/configuration_file/configuration_file.py	81.81% <100.00%> (ø)
...tostar/configuration_file/configuration_file_v1.py	95.45% <100.00%> (ø)
...r/configuration_file/configuration_file_v1_test.py	100.00% <100.00%> (ø)
...tostar/configuration_file/configuration_file_v2.py	95.38% <100.00%> (ø)
...r/configuration_file/configuration_file_v2_test.py	100.00% <100.00%> (ø)
protostar/self/__init__.py	100.00% <100.00%> (ø)
...otostar_compatibility_with_project_checker_test.py	100.00% <100.00%> (ø)
protostar/cli/network_command_util.py	89.74% <0.00%> (-10.26%)	⬇️
...r/migrator/cheatcodes/migrator_invoke_cheatcode.py	81.35% <0.00%> (-2.58%)	⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mkaput]

Approved but I'm not happy with this