Skip to content

Commit

Permalink
Bump react-native-screens (#5397)
Browse files Browse the repository at this point in the history
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

We've lost our searchbar on Android 😱 But once we bump
`react-native-screens` it works again 💪
<!-- Explain the motivation for this PR. Include "Fixes #<number>" if
applicable. -->

|BEFORE|AFTER|
|--|--|
|![Screenshot 2023-11-09 at 10 21
15](https://github.com/software-mansion/react-native-reanimated/assets/56199675/971d8b2f-6e4c-49c7-bd2f-6b3406dc5739)|![Screenshot
2023-11-09 at 10 21
41](https://github.com/software-mansion/react-native-reanimated/assets/56199675/67ee4825-eb8b-403d-915b-a9f5efd982f2)|

## Test plan
I've tested on Android (Example and Fabric Exampe)
<!-- Provide a minimal but complete code snippet that can be used to
test out this change along with instructions how to run it and a
description of the expected behavior. -->

---------

Co-authored-by: Aleksandra Cynk <aleksandracynk@Aleksandras-MacBook-Pro-3.local>
  • Loading branch information
Latropos and Aleksandra Cynk committed Nov 23, 2023
1 parent 4656b72 commit c591366
Show file tree
Hide file tree
Showing 11 changed files with 54 additions and 63 deletions.
6 changes: 3 additions & 3 deletions Example/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -508,9 +508,9 @@ PODS:
- RCT-Folly (= 2021.07.22.00)
- React-Core
- ReactCommon/turbomodule/core
- RNScreens (3.25.0):
- RNScreens (3.27.0):
- RCT-Folly (= 2021.07.22.00)
- React-Core
- React-RCTImage
- RNSVG (13.14.0):
- React-Core
- SocketRocket (0.6.1)
Expand Down Expand Up @@ -774,7 +774,7 @@ SPEC CHECKSUMS:
RNCPicker: 529d564911e93598cc399b56cc0769ce3675f8c8
RNGestureHandler: bb86e378287f7713baf3ca205423eb8109790022
RNReanimated: 518aef663d1661d60e50610fe05ebec14b404739
RNScreens: 85d3880b52d34db7b8eeebe2f1a0e807c05e69fa
RNScreens: 3c2d122f5e08c192e254c510b212306da97d2581
RNSVG: d00c8f91c3cbf6d476451313a18f04d220d4f396
SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17
Yoga: b76f1acfda8212aa16b7e26bcce3983230c82603
Expand Down
2 changes: 1 addition & 1 deletion Example/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"react-native-pager-view": "^5.4.25",
"react-native-reanimated": "link:../",
"react-native-safe-area-context": "^4.7.2",
"react-native-screens": "^3.25.0",
"react-native-screens": "^3.27.0",
"react-native-svg": "^13.14.0"
},
"devDependencies": {
Expand Down
8 changes: 4 additions & 4 deletions Example/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5988,10 +5988,10 @@ react-native-safe-area-context@^4.7.2:
resolved "https://registry.yarnpkg.com/react-native-safe-area-context/-/react-native-safe-area-context-4.7.2.tgz#1673aa99b6a9235e7faaf5a248e69795d6e54e07"
integrity sha512-5fy/hRNJ7bI/U2SliOeKf0D80J4lXPc1NsRiNS7Xaz8YTnqlzWib1ViItkwKPfufe54YKzVBMmM32RpdzvO2gg==

react-native-screens@^3.25.0:
version "3.25.0"
resolved "https://registry.yarnpkg.com/react-native-screens/-/react-native-screens-3.25.0.tgz#cf45e271ce733c9cf782fef8c9b3eb9e53faf01d"
integrity sha512-TSC2Ad0hh763I8QT6XxMsPXAagQ+RawDSdFtKRvIz9fCYr96AjRwwaqmYivbqlDywOgcRBkIVynkFtp0ThmlYw==
react-native-screens@^3.27.0:
version "3.27.0"
resolved "https://registry.yarnpkg.com/react-native-screens/-/react-native-screens-3.27.0.tgz#2ac39f78dee27df97d3b6fb11ebf8e5751aa986a"
integrity sha512-FzSUygZ7yLQyhDJZsl7wU68LwRpVtVdqOPWribmEU3Tf26FohFGGcfJx1D8lf2V2Teb8tI+IaLnXCKbyh2xffA==
dependencies:
react-freeze "^1.0.0"
warn-once "^0.1.0"
Expand Down
34 changes: 25 additions & 9 deletions FabricExample/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1168,23 +1168,39 @@ PODS:
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- RNScreens (3.25.0):
- RCT-Folly
- RNScreens (3.27.0):
- hermes-engine
- RCT-Folly (= 2021.07.22.00)
- RCTRequired
- RCTTypeSafety
- React
- React-Codegen
- React-Core
- React-debug
- React-Fabric
- React-graphics
- React-NativeModulesApple
- React-RCTFabric
- React-utils
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- RNScreens/common (= 3.25.0)
- RNScreens/common (3.25.0):
- RCT-Folly
- RNScreens/common (= 3.27.0)
- Yoga
- RNScreens/common (3.27.0):
- hermes-engine
- RCT-Folly (= 2021.07.22.00)
- RCTRequired
- RCTTypeSafety
- React
- React-Codegen
- React-Core
- React-debug
- React-Fabric
- React-graphics
- React-NativeModulesApple
- React-RCTFabric
- React-utils
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- RNSVG (13.14.0):
- hermes-engine
- RCT-Folly (= 2021.07.22.00)
Expand Down Expand Up @@ -1473,7 +1489,7 @@ SPEC CHECKSUMS:
React-perflogger: e3596db7e753f51766bceadc061936ef1472edc3
React-RCTActionSheet: 17ab132c748b4471012abbcdcf5befe860660485
React-RCTAnimation: c8bbaab62be5817d2a31c36d5f2571e3f7dcf099
React-RCTAppDelegate: 7a68d7f49d93f4899acde16ff5050854602a6ca2
React-RCTAppDelegate: 255f30d935cd51503bd8118c94682d877f8ac5db
React-RCTBlob: 1bcf3a0341eb8d6950009b1ddb8aefaf46996b8c
React-RCTFabric: 2d72175df6e0e230a13ec2a7eef184ac0a122fd3
React-RCTImage: 670a3486b532292649b1aef3ffddd0b495a5cee4
Expand All @@ -1492,7 +1508,7 @@ SPEC CHECKSUMS:
RNCPicker: 529d564911e93598cc399b56cc0769ce3675f8c8
RNGestureHandler: 039162c42c65de1228c58eb48be90c279bfde3f1
RNReanimated: 52790dde3755dc90bfecdb4df6653e83bbeac30d
RNScreens: cba72a26a6c967765a8388fe85f78e7771012ca1
RNScreens: 8e44ede8be80fbd17005680b7c86722a42d8dc73
RNSVG: df9aaada196f6a61c8e30dc55d41e6c108a954e7
SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17
Yoga: b76f1acfda8212aa16b7e26bcce3983230c82603
Expand Down
2 changes: 1 addition & 1 deletion FabricExample/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"react-native-pager-view": "^5.4.25",
"react-native-reanimated": "link:../",
"react-native-safe-area-context": "^4.7.2",
"react-native-screens": "^3.25.0",
"react-native-screens": "^3.27.0",
"react-native-svg": "^13.14.0"
},
"devDependencies": {
Expand Down
8 changes: 4 additions & 4 deletions FabricExample/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5679,10 +5679,10 @@ react-native-safe-area-context@^4.7.2:
resolved "https://registry.yarnpkg.com/react-native-safe-area-context/-/react-native-safe-area-context-4.7.2.tgz#1673aa99b6a9235e7faaf5a248e69795d6e54e07"
integrity sha512-5fy/hRNJ7bI/U2SliOeKf0D80J4lXPc1NsRiNS7Xaz8YTnqlzWib1ViItkwKPfufe54YKzVBMmM32RpdzvO2gg==

react-native-screens@^3.25.0:
version "3.25.0"
resolved "https://registry.yarnpkg.com/react-native-screens/-/react-native-screens-3.25.0.tgz#cf45e271ce733c9cf782fef8c9b3eb9e53faf01d"
integrity sha512-TSC2Ad0hh763I8QT6XxMsPXAagQ+RawDSdFtKRvIz9fCYr96AjRwwaqmYivbqlDywOgcRBkIVynkFtp0ThmlYw==
react-native-screens@^3.27.0:
version "3.27.0"
resolved "https://registry.yarnpkg.com/react-native-screens/-/react-native-screens-3.27.0.tgz#2ac39f78dee27df97d3b6fb11ebf8e5751aa986a"
integrity sha512-FzSUygZ7yLQyhDJZsl7wU68LwRpVtVdqOPWribmEU3Tf26FohFGGcfJx1D8lf2V2Teb8tI+IaLnXCKbyh2xffA==
dependencies:
react-freeze "^1.0.0"
warn-once "^0.1.0"
Expand Down
37 changes: 6 additions & 31 deletions MacOSExample/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -500,37 +500,12 @@ PODS:
- RNGestureHandler (2.13.2):
- React-Core
- RNReanimated (3.5.0):
- DoubleConversion
- FBLazyVector
- glog
- hermes-engine
- RCT-Folly
- RCTRequired
- RCTTypeSafety
- React-callinvoker
- RCT-Folly (= 2021.07.22.00)
- React-Core
- React-Core/DevSupport
- React-Core/RCTWebSocket
- React-CoreModules
- React-cxxreact
- React-hermes
- React-jsi
- React-jsiexecutor
- React-jsinspector
- React-RCTActionSheet
- React-RCTAnimation
- React-RCTAppDelegate
- React-RCTBlob
- React-RCTImage
- React-RCTLinking
- React-RCTNetwork
- React-RCTSettings
- React-RCTText
- ReactCommon/turbomodule/core
- Yoga
- RNScreens (3.25.0):
- RNScreens (3.27.0):
- RCT-Folly (= 2021.07.22.00)
- React-Core
- React-RCTImage
- RNSVG (13.14.0):
- React-Core
- SocketRocket (0.6.1)
Expand Down Expand Up @@ -789,13 +764,13 @@ SPEC CHECKSUMS:
RNCMaskedView: f7c74478c83c4fdfc5cf4df51f80c0dd5cf125c6
RNCPicker: 529d564911e93598cc399b56cc0769ce3675f8c8
RNGestureHandler: bb86e378287f7713baf3ca205423eb8109790022
RNReanimated: 7032c33fc6caf259b4872375342b72183c688fc3
RNScreens: 85d3880b52d34db7b8eeebe2f1a0e807c05e69fa
RNReanimated: 518aef663d1661d60e50610fe05ebec14b404739
RNScreens: 3c2d122f5e08c192e254c510b212306da97d2581
RNSVG: d00c8f91c3cbf6d476451313a18f04d220d4f396
SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17
Yoga: b76f1acfda8212aa16b7e26bcce3983230c82603
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a

PODFILE CHECKSUM: c7912d2be242755f04acff6ad99bd3fb81683d33

COCOAPODS: 1.14.0
COCOAPODS: 1.14.2
2 changes: 1 addition & 1 deletion MacOSExample/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"react-native-pager-view": "^5.4.25",
"react-native-reanimated": "link:../",
"react-native-safe-area-context": "^4.7.2",
"react-native-screens": "^3.25.0",
"react-native-screens": "^3.27.0",
"react-native-svg": "^13.14.0"
},
"devDependencies": {
Expand Down
8 changes: 4 additions & 4 deletions MacOSExample/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5775,10 +5775,10 @@ react-native-safe-area-context@^4.7.2:
resolved "https://registry.yarnpkg.com/react-native-safe-area-context/-/react-native-safe-area-context-4.7.2.tgz#1673aa99b6a9235e7faaf5a248e69795d6e54e07"
integrity sha512-5fy/hRNJ7bI/U2SliOeKf0D80J4lXPc1NsRiNS7Xaz8YTnqlzWib1ViItkwKPfufe54YKzVBMmM32RpdzvO2gg==

react-native-screens@^3.25.0:
version "3.25.0"
resolved "https://registry.yarnpkg.com/react-native-screens/-/react-native-screens-3.25.0.tgz#cf45e271ce733c9cf782fef8c9b3eb9e53faf01d"
integrity sha512-TSC2Ad0hh763I8QT6XxMsPXAagQ+RawDSdFtKRvIz9fCYr96AjRwwaqmYivbqlDywOgcRBkIVynkFtp0ThmlYw==
react-native-screens@^3.27.0:
version "3.27.0"
resolved "https://registry.yarnpkg.com/react-native-screens/-/react-native-screens-3.27.0.tgz#2ac39f78dee27df97d3b6fb11ebf8e5751aa986a"
integrity sha512-FzSUygZ7yLQyhDJZsl7wU68LwRpVtVdqOPWribmEU3Tf26FohFGGcfJx1D8lf2V2Teb8tI+IaLnXCKbyh2xffA==
dependencies:
react-freeze "^1.0.0"
warn-once "^0.1.0"
Expand Down
2 changes: 1 addition & 1 deletion app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"react-native-pager-view": "^5.4.25",
"react-native-reanimated": "link:../",
"react-native-safe-area-context": "^4.7.2",
"react-native-screens": "^3.25.0",
"react-native-screens": "^3.27.0",
"react-native-svg": "^13.14.0",
"react-native-web": "~0.18.12"
},
Expand Down
8 changes: 4 additions & 4 deletions app/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1564,10 +1564,10 @@ react-native-safe-area-context@^4.7.2:
resolved "https://registry.yarnpkg.com/react-native-safe-area-context/-/react-native-safe-area-context-4.7.2.tgz#1673aa99b6a9235e7faaf5a248e69795d6e54e07"
integrity sha512-5fy/hRNJ7bI/U2SliOeKf0D80J4lXPc1NsRiNS7Xaz8YTnqlzWib1ViItkwKPfufe54YKzVBMmM32RpdzvO2gg==

react-native-screens@^3.25.0:
version "3.25.0"
resolved "https://registry.yarnpkg.com/react-native-screens/-/react-native-screens-3.25.0.tgz#cf45e271ce733c9cf782fef8c9b3eb9e53faf01d"
integrity sha512-TSC2Ad0hh763I8QT6XxMsPXAagQ+RawDSdFtKRvIz9fCYr96AjRwwaqmYivbqlDywOgcRBkIVynkFtp0ThmlYw==
react-native-screens@^3.27.0:
version "3.27.0"
resolved "https://registry.yarnpkg.com/react-native-screens/-/react-native-screens-3.27.0.tgz#2ac39f78dee27df97d3b6fb11ebf8e5751aa986a"
integrity sha512-FzSUygZ7yLQyhDJZsl7wU68LwRpVtVdqOPWribmEU3Tf26FohFGGcfJx1D8lf2V2Teb8tI+IaLnXCKbyh2xffA==
dependencies:
react-freeze "^1.0.0"
warn-once "^0.1.0"
Expand Down

0 comments on commit c591366

Please sign in to comment.