Bump react-native-screens #5397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Nov 23, 2023
piaskowyk
approved these changes
Nov 23, 2023
Latropos
added a commit
that referenced
this pull request
Nov 24, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary We've lost our searchbar on Android 😱 But once we bump `react-native-screens` it works again 💪 <!-- Explain the motivation for this PR. Include "Fixes #<number>" if applicable. --> |BEFORE|AFTER| |--|--| ||| ## Test plan I've tested on Android (Example and Fabric Exampe) <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. --> --------- Co-authored-by: Aleksandra Cynk <aleksandracynk@Aleksandras-MacBook-Pro-3.local>
Latropos
added a commit
that referenced
this pull request
Dec 12, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary We've lost our searchbar on Android 😱 But once we bump `react-native-screens` it works again 💪 <!-- Explain the motivation for this PR. Include "Fixes #<number>" if applicable. --> |BEFORE|AFTER| |--|--| ||| ## Test plan I've tested on Android (Example and Fabric Exampe) <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. --> --------- Co-authored-by: Aleksandra Cynk <aleksandracynk@Aleksandras-MacBook-Pro-3.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've lost our searchbar on Android 😱 But once we bump
react-native-screensit works again 💪Test plan
I've tested on Android (Example and Fabric Exampe)