[useAnimatedKeyboard][Android] Fix some keyboard issues #5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
requested changes
Feb 16, 2024
android/src/main/java/com/swmansion/reanimated/keyboard/Keyboard.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/reanimated/keyboard/Keyboard.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/reanimated/keyboard/KeyboardAnimationCallback.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/reanimated/keyboard/KeyboardAnimationCallback.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/reanimated/keyboard/KeyboardAnimationCallback.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/reanimated/keyboard/KeyboardAnimationCallback.java
Outdated
Show resolved
Hide resolved
tjzel
approved these changes
Feb 20, 2024
android/src/main/java/com/swmansion/reanimated/keyboard/Keyboard.java
Outdated
Show resolved
Hide resolved
piaskowyk
changed the title
piaskowyk
changed the title
piaskowyk
commented
Feb 27, 2024
android/src/main/java/com/swmansion/reanimated/keyboard/Keyboard.java
Outdated
Show resolved
Hide resolved
This was referenced Feb 28, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
## Summary Split of #5666 It resolves the problem of non-monotonic values during animation. Previously, we were intercepting all keyboard events, but not all of them were relevant to keyboard animation.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
## Summary Split of #5666 It fixes the issue where the state was incorrect if a keyboard transition was canceled.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
## Summary Split of #5666 It ensures proper respect for auto-hiding navigation bars on Android devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses a few Android keyboard-related issues:
Test plan
Run useAnimatedKeyboard Example on physical Android device.