Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[useAnimatedKeyboard][Android] Filter keyboard events #5740

Merged
merged 9 commits into from
Mar 1, 2024

Conversation

piaskowyk
Copy link
Member

Summary

Split of #5666

It resolves the problem of non-monotonic values during animation. Previously, we were intercepting all keyboard events, but not all of them were relevant to keyboard animation.

@piaskowyk piaskowyk marked this pull request as ready for review February 28, 2024 16:43
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Base automatically changed from @piaskowyk/keyboard-refactor to main March 1, 2024 10:13
@piaskowyk piaskowyk force-pushed the @piaskowyk/android-keyboard-filter-events branch from b4d978a to f231d32 Compare March 1, 2024 10:35
@piaskowyk piaskowyk added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit ddd3f83 Mar 1, 2024
9 checks passed
@piaskowyk piaskowyk deleted the @piaskowyk/android-keyboard-filter-events branch March 1, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants