Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypedData in line with SNIP-12 #1353

Closed
NikitaMishin opened this issue May 14, 2024 · 3 comments
Closed

Update TypedData in line with SNIP-12 #1353

NikitaMishin opened this issue May 14, 2024 · 3 comments
Assignees

Comments

@NikitaMishin
Copy link

Feature Request

Do you guys plan to support snip-12

I see that currently only revision 0 supported https://github.com/starknet-io/SNIPs/blob/main/SNIPS/snip-12.md

class StarkNetDomain(TypedDict):

@ddoktorski
Copy link
Collaborator

Hi @NikitaMishin
Thank you for opening the issue. Could you please let me know if you need this implementation for a project you're currently working on?

@NikitaMishin
Copy link
Author

yes but not critical since we can use revision0 but for better user experience eventually good to have support of revision1

Hi @NikitaMishin Thank you for opening the issue. Could you please let me know if you need this implementation for a project you're currently working on?

@ddoktorski ddoktorski changed the title Snip12 Update TypedData in line with SNIP-12 Jun 4, 2024
@ddoktorski
Copy link
Collaborator

@NikitaMishin

I can confirm that we are going to work towards supporting SNIP-12. Unfortunately, I am unable to provide a timeline at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants