Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MerkleTree and merkletree support in TypedData #1363

Merged
merged 98 commits into from
Jun 27, 2024
Merged

Add MerkleTree and merkletree support in TypedData #1363

merged 98 commits into from
Jun 27, 2024

Conversation

franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Jun 20, 2024 •
edited
Loading

Relates #1353

Introduced changes

  • Add HashMethod.hash_many()
  • Add Parameter.contains field to support merkletree type
  • Add MerkleTree dataclass
  • Add BasicType enum with felt, selector, merkletree and shortstring
  • Add merkle tree tests; Extend typed data tests with merkle tree cases

  • This PR contains breaking changes

franciszekjob and others added 30 commits June 14, 2024 16:03
@franciszekjob
Differentiate typed data files by revision
95fe8a8
@franciszekjob
Add HashMethod
139f970
@franciszekjob
Add Revision enum; Rename StarkNetDomain to Domain
1317848
@franciszekjob
Add tests to revision 1
2cf0aaa
@franciszekjob
Remove prints
9d9fda3
@franciszekjob
Add more rev 1 test cases to test_type_hash
f67cdb7
@franciszekjob
Change values param to List[int] in HashMethod.hash()
5469dd3
@franciszekjob
Add DomainSchema; Add RevisionField and ChainIdField
1be0060
@franciszekjob
Move HashMethod to separate file
9781a21
@franciszekjob
Refactor Domain.to_dict()
a7e7f89
@franciszekjob
Update comment
57c16ec
@franciszekjob
Add TypedData._hash_method field
c648f84
@franciszekjob
Remove TypedData._hash_method field
74cf615
@franciszekjob
Update docs
549e143
@franciszekjob
Update docs
9c67d18
@franciszekjob
Merge branch 'franciszekjob/1353-snip-12' of https://github.com/softw…
be1e1ec 
…are-mansion/starknet.py into franciszekjob/1353-snip-12
@franciszekjob
Update comment
23562a4
@franciszekjob
Reduce Domain._verify_types()
1c4cde6
@franciszekjob
Remove unnecessary variable duplication
e158122
@franciszekjob
Remove unused functions
57ed19f
@franciszekjob
Add merkle tree type data jsons
64a7a6a
@franciszekjob
Add HashMethod.hash_many()
599f6bd
@franciszekjob
Add MerkleTree dataclass; Add merkle tree tests
8b6e28d
@franciszekjob
Add Parameter.contains to handle merkle parameter
d7540eb
@franciszekjob
Introduce merkle trees in TypedData; Add merkle tree cases in typed…
9290b5e 
… data tests
@franciszekjob
Convert TypedData._hash_method to @property
3d92324
@franciszekjob
Change Domain.revision type to Revision
0c651d4
@franciszekjob
Use equality comparison for resolved_revision
961e489
@franciszekjob
Merge branch 'franciszekjob/1353-snip-12' of https://github.com/softw…
e98ed80 
…are-mansion/starknet.py into franciszekjob/1353-snip-12
@franciszekjob
Set revision in Domain typed dict to be Optional
59a7b2e
franciszekjob and others added 3 commits June 24, 2024 17:06
@franciszekjob @ddoktorski
Update starknet_py/net/schemas/common.py
3574b8c 
Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>
@franciszekjob @ddoktorski
Update starknet_py/net/schemas/common.py
0412e27 
Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>
@franciszekjob
Merge branch 'franciszekjob/1353-snip-12' of https://github.com/softw…
6d59203 
…are-mansion/starknet.py into franciszekjob/1353-2-merkletree
@franciszekjob
Copy link
Collaborator Author

franciszekjob commented Jun 24, 2024 •
edited
Loading

Add variable naming changes in MerkleTree class have been applied.

Base automatically changed from franciszekjob/1353-snip-12 to development June 24, 2024 15:40
ddoktorski
ddoktorski requested changes Jun 24, 2024
View reviewed changes
starknet_py/hash/hash_method.py Show resolved Hide resolved
starknet_py/utils/merkle_tree.py Outdated Show resolved Hide resolved
starknet_py/utils/merkle_tree.py Outdated Show resolved Hide resolved
starknet_py/utils/merkle_tree_test.py Show resolved Hide resolved
starknet_py/utils/merkle_tree.py Outdated Show resolved Hide resolved
starknet_py/utils/merkle_tree_test.py Outdated Show resolved Hide resolved
starknet_py/net/models/typed_data.py Show resolved Hide resolved
ddoktorski
ddoktorski reviewed Jun 26, 2024
View reviewed changes
starknet_py/hash/hash_method.py Show resolved Hide resolved
starknet_py/utils/typed_data.py Outdated Show resolved Hide resolved
ddoktorski
ddoktorski reviewed Jun 26, 2024
View reviewed changes
starknet_py/utils/typed_data.py Show resolved Hide resolved
starknet_py/utils/typed_data.py Outdated Show resolved Hide resolved
starknet_py/utils/typed_data.py Outdated Show resolved Hide resolved
franciszekjob and others added 2 commits June 27, 2024 01:24
@franciszekjob @ddoktorski
Update starknet_py/utils/typed_data.py
f1dda04 
Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>
@franciszekjob @ddoktorski
Update starknet_py/utils/typed_data.py
68d6217 
Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>
ddoktorski
ddoktorski approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint only and then it will be good to go 🚀

starknet_py/utils/typed_data.py Show resolved Hide resolved
@franciszekjob franciszekjob merged commit 2e17b16 into development Jun 27, 2024
16 checks passed
@franciszekjob franciszekjob deleted the franciszekjob/1353-2-merkletree branch June 27, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

Assignees

@franciszekjob franciszekjob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franciszekjob @ddoktorski