-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify types in TypedData
in line with SNIP-12
#1369
Merged
franciszekjob
merged 129 commits into
development
from
franciszekjob/1353-3-verify-types
Jun 29, 2024
Merged
Verify types in TypedData
in line with SNIP-12
#1369
franciszekjob
merged 129 commits into
development
from
franciszekjob/1353-3-verify-types
Jun 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are-mansion/starknet.py into franciszekjob/1353-snip-12
…are-mansion/starknet.py into franciszekjob/1353-snip-12
…software-mansion/starknet.py into franciszekjob/1353-3-verify-types
…software-mansion/starknet.py into franciszekjob/1353-3-verify-types
…software-mansion/starknet.py into franciszekjob/1353-3-verify-types
Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>
Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>
…software-mansion/starknet.py into franciszekjob/1353-3-verify-types
ddoktorski
reviewed
Jun 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #1369 +/- ##
================================================
- Coverage 96.97% 86.77% -10.21%
================================================
Files 93 98 +5
Lines 4766 4984 +218
================================================
- Hits 4622 4325 -297
- Misses 144 659 +515
|
This reverts commit 199d290.
ddoktorski
approved these changes
Jun 28, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #1353
Introduced changes
Ensure type verification logic in line with guidelines. Restrictions related to
enum
basic type will be added separately in next PRs.*
, dangling types