Add missing field to ExecutionResources #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #1301 +/- ##
===============================================
+ Coverage 97.96% 97.99% +0.02%
===============================================
Files 93 93
Lines 4580 4582 +2
===============================================
+ Hits 4487 4490 +3
+ Misses 93 92 -1
|
DelevoXDG
approved these changes
Feb 23, 2024
THenry14
approved these changes
Feb 23, 2024
Comment on lines
+436
to
+443
| assert receipt.execution_resources is not None | ||
| assert receipt.execution_resources.steps is not None | ||
| assert receipt.execution_resources.segment_arena_builtin is not None | ||
| assert receipt.execution_resources.bitwise_builtin_applications is not None | ||
| assert receipt.execution_resources.ec_op_builtin_applications is not None | ||
| assert receipt.execution_resources.memory_holes is not None | ||
| assert receipt.execution_resources.pedersen_builtin_applications is not None | ||
| assert receipt.execution_resources.range_check_builtin_applications is not None |
There was a problem hiding this comment.
nitpick: since this is a hardcoded transaction, it should be possible to just assert specific values that we expect (and not just asserting that it is not None), which would give us another layer of testing (I mean serialization).
if you agree, I'd suggest we open an issue and deal with it in a separate PR, at later date.
There was a problem hiding this comment.
In an ideal scenario, we should probably have unit tests for out RPC schemas 😅 However the check that you suggest can definitely improve this test. Let's discuss it further in #1219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1300
Missing field: https://github.com/starkware-libs/starknet-specs/blob/v0.6.0/api/starknet_api_openrpc.json#L3848
Introduced changes
segment_arena_builtinfield toExecutionResourcesfields.Integerinstead ofFeltfor serializing/deserializingExecutionResourcesfields to align with RPC specification