Set chain ID in StarknetAccount initializer #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelevoXDG
changed the base branch from
main
to
revert-142-feat/138-remove-starknet-chain-id
DelevoXDG
changed the title
THenry14
approved these changes
Feb 19, 2024
Base automatically changed from
revert-142-feat/138-remove-starknet-chain-id
to
main
February 19, 2024 10:24
DelevoXDG
force-pushed
the
feat/153-chain-id-account
branch
from
4cd0f43
to
e4d66f3
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Linked issues
Closes #153
Breaking changes
StarknetAccountconstructor now has a mandatorychainIdargumentStarknetAccountProtocolnow haschainId: StarknetChainIdproperty