Support RPC 0.7.0 #162
Merged
Support RPC 0.7.0 #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `dataAvailability` to `StarknetExecutionResources`; Add `StarknetDataAvailability - Add `executionResources` to tx traces - Add `StarknetComputationResources` - Add `computationResources` to `StarknetFunctionInvocation` - Add `StarknetResources` protocol with common fields
- Prefund account with `5_000_000_000_000_000`->`5_000_000_000_000_000_000` - Change max fee in declare methods to `1_000_000_000_000_000`->`10_000_000_000_000_000`
- Add `dataGasConsumed`, `dataGasPrice` fields to `StarknetFeeEstimate` - Update `.toResourceBounds()` extension - Update overheads - Use new logic
This was referenced Mar 21, 2024
Merged
ddoktorski
reviewed
Mar 21, 2024
| public let type: StarknetTransactionType = .deployAccount | ||
|
|
||
| private enum CodingKeys: String, CodingKey { | ||
| case validateInvocation = "validate_invocation" | ||
| case constructorInvocation = "constructor_invocation" | ||
| case feeTransferInvocation = "fee_transfer_invocation" | ||
| case stateDiff = "state_diff" | ||
| case executionResources = "execution_resources" | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
There was a discussion on Slack that execution_resources should be added to L1HandlerTransactionTrace and it was also mentioned in software-mansion/starknet.py#1312 (comment). Not sure if we want to add it as optional now or wait until it is fixed in the spec.
There was a problem hiding this comment.
Yeah, I thought it would be reasonable not to change this until the spec is updated, but I suppose making it optional won't hurt
… and `StarknetExecutionResources` - Adjust tests
THenry14
approved these changes
Mar 25, 2024
| func toResourceBounds(amountOverhead: Double = 0.1, unitPriceOverhead: Double = 0.5) -> StarknetResourceBoundsMapping { | ||
| let maxAmount = addOverhead(self.gasConsumed.value, amountOverhead).toUInt64AsHexClamped() | ||
| func toResourceBounds(amountOverhead: Double = 0.5, unitPriceOverhead: Double = 0.5) -> StarknetResourceBoundsMapping { | ||
| let maxAmount = self.gasPrice == .zero ? UInt64AsHex.zero : addOverhead(self.overallFee.value / self.gasPrice.value, amountOverhead).toUInt64AsHexClamped() |
There was a problem hiding this comment.
what are the scenarios for gasPrice equal to zero?
There was a problem hiding this comment.
There aren't really any likely scenarios, added these for the same reasons I outlined before:
(0,0) resources can be used in
estimateFee/simulateTransactions. It normally shouldn't happen, but I suppose better safe than sorry?
* Introduce `StarknetTransactionVersion` enum - Use it instead of `Felt` in tx classes - Update `TransactionWrapper` * Reorder cases in `TransactionWrapper`
* Update recepits in line with the spec - Remove `StarknetPendingTransactionReceipt`, remove it uses from derived classes - Rename `Starknet[..]TransactionReceipt`->`Starknet[..]TransactionReceiptProtocol` - Rename `StarknetProcessed[..]TransactionReceipt`->`Starknet[..]TransactionReceiptWithBlockInfo` - Rename `StarknetPending[..]TransactionReceipt`->`Starknet[..]TransactionReceipt` - Add `StarknetDeployTransactionReceipt` a.k.a pending deploy receipt - Update `TransactionReceiptWrapper` * Merge receipts with and w/o block info - Remove `StarknetTransactionReceiptWithBlockInfo` protocol - Add optional `blockHash` and `blockNumber` to `StarknetTransactionReceipt` protocol - Merge `Starknet[..]TransactionReceiptWithBlockInfo` and `Starknet[..]TransactionReceipt` - Remove `StarknetInvokeTransactionReceiptWithBlockInfo` - Add optional `blockHash` and `blockNumber` to `Starknet[..]TransactionReceipt` - Update `TransactionReceiptWrapper`: don't take block info into account
THenry14
approved these changes
Mar 27, 2024
* Use multipliers instead of overheads in fee calculation utils * Add `executeV1`, `executeV3` methods in `StarknetAccount` with estimate fee multipliers * Fix `StarknetFeeEstimate.toMaxFee()` docstring * Add docstrings for `executeV1`, `executeV3` methods * Update docstrings for `executeVX` with `call(s)` as only argument - Make them in line with the new methods with multipliers * Add tests * Review changes * Review changes * Update fee utils docstrings - Remove percentages - Remove typo char Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com> * Remove `executeV1|3` short descriptions; Keep only long ones * Remove `executeV1|3` short descriptions; Keep only long ones (2) --------- Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack
-- Support RPC 0.7.0 (#162)
-- Add
executemethods with custom fee multipliers (#163)-- Add transaction version enum (#164)
-- Refactor receipts (#165)
Describe your changes
Add support for RPC 0.7.0
StarknetExecutionResources; AddStarknetComputationResourcesexecutionResourcesto tx tracescomputationResourcestoStarknetFunctionInvocationdataGasConsumedanddataGasPricetoStarknetFeeEstimatemaxAmountcalculation logic intoResourceBounds()toResourceBounds()by default; Use 1.5 multiplier (analogous to 0.5 overhead)executeV1,executeV3methods inStarknetAccountwith estimate fee multipliersStarknetTransactionVersionenum; Use it instead of rawFeltvaluesprocessed) and without it (a.k.apending)StarknetPendingTransactionReceipt,StarknetProcessedTransactionReceiptprotocolsblockHashandblockNumbertoStarknetTransactionReceiptprotocol and all derivedStarknet[..]TransactionReceiptstructsOther
Linked issues
Closes #148
Closes #147
Breaking changes
StarknetFeeEstimateextension fee calculation utilstoResourceBounds()now takesamountMultiplier,unitPriceMultiplierinstead ofamountOverhead,unitPriceOverheadtoMaxFee()now takesmultiplierinstead ofoverheadversionofStarknetTransactionis now of typeStarknetTransactionVersioninstead ofFelt; This applies to all derived transaction structsStarknetPendingTransactionReceipt,StarknetProcessedTransactionReceiptprotocolsStarknet[..]TransactionReceiptprotocols toStarknet[..]TransactionReceiptProtocolStarknetPending[..]TransactionReceiptandStarknetProcessed[..]TransactionReceiptclasses; UseStarknet[..]TransactionReceiptclasses with optionalblockHashandblockNumberinstead