Add execute methods with custom fee multipliers
#163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te fee multipliers
- Make them in line with the new methods with multipliers
This was referenced Mar 21, 2024
Merged
Merged
DelevoXDG
force-pushed
the
feat/148-2-fee-multipliers
branch
from
eb5d63c
to
7fb6ebe
Compare
ddoktorski
reviewed
Mar 21, 2024
- Remove percentages - Remove typo char Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>
THenry14
reviewed
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack
-- Support RPC 0.7.0 (#162)
-- Add
executemethods with custom fee multipliers (#163)-- Add transaction version enum (#164)
-- Refactor receipts (#165)
Describe your changes
executeV1,executeV3methods inStarknetAccountwith estimate fee multipliersexecuteVXwithcall(s)as only argument to be in line with the new methodsLinked issues
Closes
Breaking changes
StarknetFeeEstimateextension fee calculation utilstoResourceBounds()now takesamountMultiplier,unitPriceMultiplierinstead ofamountOverhead,unitPriceOverheadtoMaxFee()now takesmultiplierinstead ofoverhead