Skip to content

Commit

Permalink
Forge a confirmed root before halting for RPC inspection (#10061)
Browse files Browse the repository at this point in the history
(cherry picked from commit 1da1667)
  • Loading branch information
mvines authored and mergify-bot committed May 15, 2020
1 parent b9a8015 commit 093be9a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 0 additions & 1 deletion core/src/commitment.rs
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ impl BlockCommitmentCache {
}
}

#[cfg(test)]
pub(crate) fn set_get_largest_confirmed_root(&mut self, root: Slot) {
self.largest_confirmed_root = root;
}
Expand Down
7 changes: 7 additions & 0 deletions core/src/validator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,13 @@ impl Validator {
);

if config.dev_halt_at_slot.is_some() {
// Simulate a confirmed root to avoid RPC errors with CommitmentmentConfig::max() and
// to ensure RPC endpoints like getConfirmedBlock, which require a confirmed root, work
block_commitment_cache
.write()
.unwrap()
.set_get_largest_confirmed_root(bank_forks.read().unwrap().root());

// Park with the RPC service running, ready for inspection!
warn!("Validator halted");
std::thread::park();
Expand Down

0 comments on commit 093be9a

Please sign in to comment.