validator: Forge a confirmed root before halting for RPC inspection #10061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10061 +/- ##
=========================================
- Coverage 81.5% 81.4% -0.2%
=========================================
Files 283 283
Lines 65782 65784 +2
=========================================
- Hits 53660 53595 -65
- Misses 12122 12189 +67 |
| block_commitment_cache | ||
| .write() | ||
| .unwrap() | ||
| .set_get_largest_confirmed_root(bank_forks.read().unwrap().root()); |
There was a problem hiding this comment.
Do we have any information about whether that is, in fact, a confirmed root?
There was a problem hiding this comment.
Oh, I see, this is just a quick workaround because the answer is no, right?
CriesofCarrots
approved these changes
May 15, 2020
mergify bot
pushed a commit
that referenced
this pull request
May 15, 2020
(cherry picked from commit 1da1667) # Conflicts: # core/src/commitment.rs
mergify bot
pushed a commit
that referenced
this pull request
May 15, 2020
(cherry picked from commit 1da1667)
solana-grimes
pushed a commit
that referenced
this pull request
May 15, 2020
Merged
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solana block-production, amongst others, didn't work when--dev-halt-at-slotis used to park a validator for RPC inspection due to the lack of a confirmed root (that is, allCommitmentConfig::max()RPC requests fail)