Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote downstream from Bank updates #1129

Closed
garious opened this issue Sep 5, 2018 · 0 comments
Closed

Vote downstream from Bank updates #1129

garious opened this issue Sep 5, 2018 · 0 comments
Assignees
@garious
Milestone
v0.9 Swamis

Comments

@garious
Copy link
Contributor

garious commented Sep 5, 2018

Currently VoteStage votes without hashing the bank state. It simply tells the leader, "I received exactly this much of the ledger." Instead, that functionality should be merged into the ReplicateStage, and voting should occur after the call to process_entries.
@garious garious added this to the v0.8 Windansea milestone Sep 5, 2018
This was referenced Sep 5, 2018
Closed
Closed
@garious garious assigned CriesofCarrots and unassigned carllin Sep 6, 2018
@CriesofCarrots CriesofCarrots mentioned this issue Sep 10, 2018
Closed
@garious garious assigned garious and unassigned CriesofCarrots Sep 11, 2018
@garious garious modified the milestones: v0.8 Windansea, v0.9 Swamis Sep 12, 2018
@garious garious mentioned this issue Sep 25, 2018
Merged
vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
@dependabot
build(deps-dev): bump @typescript-eslint/parser in /token-lending/js (s…
6f7c0f7 
…olana-labs#1129)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.14.0 to 4.14.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.14.1/packages/parser)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
CriesofCarrots pushed a commit to CriesofCarrots/solana that referenced this issue May 1, 2024
@apfitzge
forwarder uses working bank as filter (solana-labs#1129)
79ae84e
yihau pushed a commit that referenced this issue May 14, 2024
@mergify @apfitzge @yihau
v1.18: forwarder uses working bank as filter (backport of #1129) (#1136)
e7021a3 
forwarder uses working bank as filter (#1129)

(cherry picked from commit 79ae84e)

Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
yihau pushed a commit to yihau/solana that referenced this issue May 15, 2024
@mergify @apfitzge
v1.18: forwarder uses working bank as filter (backport of solana-labs…
83ca778 
…#1129) (solana-labs#1136)

forwarder uses working bank as filter (solana-labs#1129)

(cherry picked from commit 79ae84e)

Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garious garious

Labels
None yet
Projects
None yet
Milestone
v0.9 Swamis
Development

No branches or pull requests
3 participants
@garious @CriesofCarrots @carllin