Move vote into ReplicateStage after process_entries #1173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
move-vote-into-replicate
branch
from
0da8b1e to
228f80f
Compare
|
Cool, thanks @CriesofCarrots. I'll take this one from here. I'm not sure this will make it into 0.8, because it'll affect finality times. I'd want to coordinate with @pgarg66 to see how we can measure the change before and after this PR. |
|
Rebased in #1328 |
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
…1173) Bumps [@rollup/plugin-babel](https://github.com/rollup/plugins) from 5.2.2 to 5.2.3. - [Release notes](https://github.com/rollup/plugins/releases) - [Commits](rollup/plugins@babel-v5.2.2...babel-v5.2.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not implement the 1sec sleep on validator votes from
VoteStage::runI played around with a couple different methods, but didn't want to delay this PR any more.
Fixes #1129